You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by nielsbasjes <gi...@git.apache.org> on 2016/08/01 11:15:23 UTC
[GitHub] flink pull request #2317: [FLINK-4287] Ensure the yarn-session.sh classpath ...
GitHub user nielsbasjes opened a pull request:
https://github.com/apache/flink/pull/2317
[FLINK-4287] Ensure the yarn-session.sh classpath contains all Hadoop related paths
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nielsbasjes/flink FLINK-4287
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2317.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2317
----
commit eb157a6b88ed7c493ae061d4d959cf282c4d3439
Author: Niels Basjes <nb...@bol.com>
Date: 2016-08-01T10:11:11Z
[FLINK-4287] Ensure the yarn-session.sh classpath contains all Hadoop related paths
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2317: [FLINK-4287] Ensure the yarn-session.sh classpath ...
Posted by nielsbasjes <gi...@git.apache.org>.
Github user nielsbasjes commented on a diff in the pull request:
https://github.com/apache/flink/pull/2317#discussion_r72990290
--- Diff: flink-dist/src/main/flink-bin/yarn-bin/yarn-session.sh ---
@@ -52,5 +52,5 @@ log_setting="-Dlog.file="$log" -Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4
export FLINK_CONF_DIR
-$JAVA_RUN $JVM_ARGS -classpath $CC_CLASSPATH:$HADOOP_CLASSPATH:$HADOOP_CONF_DIR:$YARN_CONF_DIR $log_setting org.apache.flink.yarn.cli.FlinkYarnSessionCli -j $FLINK_LIB_DIR/flink-dist*.jar "$@"
--- End diff --
Thanks. Good catch.
I changed the script in my installed 1.0.3 version and then committed that.
I missed the change in the classname.
As you can see I just fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2317: [FLINK-4287] Ensure the yarn-session.sh classpath contain...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2317
Woops. Didn't end up merging #2320 so this got overlooked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2317: [FLINK-4287] Ensure the yarn-session.sh classpath contain...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2317
Thanks @nielsbasjes. Will merge with #2320.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2317: [FLINK-4287] Ensure the yarn-session.sh classpath ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2317
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2317: [FLINK-4287] Ensure the yarn-session.sh classpath ...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2317#discussion_r75126672
--- Diff: flink-dist/src/main/flink-bin/yarn-bin/yarn-session.sh ---
@@ -52,5 +52,5 @@ log_setting="-Dlog.file="$log" -Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4
export FLINK_CONF_DIR
-$JAVA_RUN $JVM_ARGS -classpath $CC_CLASSPATH:$HADOOP_CLASSPATH:$HADOOP_CONF_DIR:$YARN_CONF_DIR $log_setting org.apache.flink.yarn.cli.FlinkYarnSessionCli -j $FLINK_LIB_DIR/flink-dist*.jar "$@"
--- End diff --
The name was changed recently (some months ago). Niels was just on an old base.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2317: [FLINK-4287] Ensure the yarn-session.sh classpath contain...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2317
Rebased and ready to go. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2317: [FLINK-4287] Ensure the yarn-session.sh classpath ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2317#discussion_r72981367
--- Diff: flink-dist/src/main/flink-bin/yarn-bin/yarn-session.sh ---
@@ -52,5 +52,5 @@ log_setting="-Dlog.file="$log" -Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4
export FLINK_CONF_DIR
-$JAVA_RUN $JVM_ARGS -classpath $CC_CLASSPATH:$HADOOP_CLASSPATH:$HADOOP_CONF_DIR:$YARN_CONF_DIR $log_setting org.apache.flink.yarn.cli.FlinkYarnSessionCli -j $FLINK_LIB_DIR/flink-dist*.jar "$@"
--- End diff --
Why did you change the qualified name of the `FlinkYarnSessionCli` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---