You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "littlepangdi (via GitHub)" <gi...@apache.org> on 2023/04/17 08:31:30 UTC
[GitHub] [incubator-pegasus] littlepangdi opened a new pull request, #1448: add deprecated marker to TableConnector.Close()
littlepangdi opened a new pull request, #1448:
URL: https://github.com/apache/incubator-pegasus/pull/1448
### What problem does this PR solve? <!--add issue link with summary if exists-->
fix #1446
### What is changed and how does it work?
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
##### Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
##### Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] codecov-commenter commented on pull request #1448: add deprecated marker to TableConnector.Close()
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1448:
URL: https://github.com/apache/incubator-pegasus/pull/1448#issuecomment-1512340073
## [Codecov](https://codecov.io/gh/apache/incubator-pegasus/pull/1448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@1beb24a`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1448 +/- ##
=========================================
Coverage ? 53.38%
=========================================
Files ? 27
Lines ? 2527
Branches ? 0
=========================================
Hits ? 1349
Misses ? 1132
Partials ? 46
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] littlepangdi commented on pull request #1448: add deprecated marker to TableConnector.Close()
Posted by "littlepangdi (via GitHub)" <gi...@apache.org>.
littlepangdi commented on PR #1448:
URL: https://github.com/apache/incubator-pegasus/pull/1448#issuecomment-1510967604
This pr is also related to #1385 , normally, when replica server is restarted , client should update config and build connect with another server ip.
I suspect that the reason config is not updated successful is that `TableConnector.Close()` is called and `loopForAutoUpdate()` is interrupted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] hycdong merged pull request #1448: doc(go-client): add deprecated marker to TableConnector.Close()
Posted by "hycdong (via GitHub)" <gi...@apache.org>.
hycdong merged PR #1448:
URL: https://github.com/apache/incubator-pegasus/pull/1448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org