[jira] [Commented] (FLINK-9468) get outputLimit of LimitedConnectionsFileSystem incorrectly

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493509#comment-16493509 ] 

ASF GitHub Bot commented on FLINK-9468:
---------------------------------------

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/6094

    [FLINK-9468][filesystem] fix get outputLimit in LimitedConnectionsFileSystem#createStream() incorrectly

    ## What is the purpose of the change
    
    This PR fixes the bug of getting `outputLimit` incorrectly in `LimitedConnectionsFileSystem#createStream()`.
    
    ## Brief change log
    
      - *get outputLimit in LimitedConnectionsFileSystem#createStream() correctly.*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
    no

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink FLINK-9468

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6094.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6094
    
----
commit ed2197152725f55aafe357453e05b834e62b6076
Author: sihuazhou <su...@...>
Date:   2018-05-29T13:03:03Z

    get outputLimit in LimitedConnectionsFileSystem#createStream() correctly.

----


> get outputLimit of LimitedConnectionsFileSystem incorrectly
> -----------------------------------------------------------
>
>                 Key: FLINK-9468
>                 URL: https://issues.apache.org/jira/browse/FLINK-9468
>             Project: Flink
>          Issue Type: Bug
>          Components: FileSystem
>    Affects Versions: 1.5.0
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Blocker
>             Fix For: 1.6.0, 1.5.1
>
>
> In {{LimitedConnectionsFileSystem#createStream}}, we get the outputLimit incorrectly.
> {code:java}
> private <T extends StreamWithTimeout> T createStream(
> 	final SupplierWithException<T, IOException> streamOpener,
> 	final HashSet<T> openStreams,
> 	final boolean output) throws IOException {
> final int outputLimit = output && maxNumOpenInputStreams > 0 ? maxNumOpenOutputStreams : Integer.MAX_VALUE;
> /*....*/
> }
> {code}
> should be 
> {code:java}
> private <T extends StreamWithTimeout> T createStream(
> 	final SupplierWithException<T, IOException> streamOpener,
> 	final HashSet<T> openStreams,
> 	final boolean output) throws IOException {
> final int outputLimit = output && maxNumOpenOutputStreams > 0 ? maxNumOpenOutputStreams : Integer.MAX_VALUE;
> /*....*/
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)