[GitHub] [incubator-brpc] zyearn commented on a change in pull request #1005: ignore ELIMIT for circuit breaker

[GitBox <gi...@apache.org>]

zyearn commented on a change in pull request #1005: ignore ELIMIT for circuit breaker
URL: https://github.com/apache/incubator-brpc/pull/1005#discussion_r361895580
 
 

 ##########
 File path: src/brpc/circuit_breaker.cpp
 ##########
 @@ -56,6 +65,24 @@ namespace {
 
 #define EPSILON (FLAGS_circuit_breaker_epsilon_value)
 
+std::once_flag g_init_ignored_error_codes_once;
+std::set<int> g_ignored_error_codes;
 
 Review comment:
   这个要实现成指针，第一次使用时初始化，不然会在main函数之前还未构造但被使用 or main函数之后已析构但还在使用

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org