You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "vdombrovski (via GitHub)" <gi...@apache.org> on 2023/01/24 07:41:36 UTC

[GitHub] [cloudstack-go] vdombrovski opened a new pull request, #45: Implement resourceiconresponse as interface{}

vdombrovski opened a new pull request, #45:
URL: https://github.com/apache/cloudstack-go/pull/45

   All "icon" fields are set to be of resourceiconresponse type, however that type is not defined anywhere, making the icon field resolving to a string.
   
   This isn't correct as ACS returns the Icon as an object, which in term causes these types of error:
   
   ```sh
   json: cannot unmarshal object into Go struct field VirtualMachinesMetric.virtualmachine.icon of type string
   ```
   
   This change sets the type of resourceiconresponse type to be an empty interface{}, to guarantee some backward compatibility and ensure that the unmarshalling works as intended.
   
   Tested againt ACS 4.17.1
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-go] yelbom commented on pull request #45: Implement resourceiconresponse as interface{}

Posted by "yelbom (via GitHub)" <gi...@apache.org>.
yelbom commented on PR #45:
URL: https://github.com/apache/cloudstack-go/pull/45#issuecomment-1529129092

   🤷‍♂️


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-go] shwstppr commented on pull request #45: Implement resourceiconresponse as interface{}

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #45:
URL: https://github.com/apache/cloudstack-go/pull/45#issuecomment-1491361551

   Merging based on approvals


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-go] shwstppr merged pull request #45: Implement resourceiconresponse as interface{}

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr merged PR #45:
URL: https://github.com/apache/cloudstack-go/pull/45


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-go] vdombrovski commented on pull request #45: Implement resourceiconresponse as interface{}

Posted by "vdombrovski (via GitHub)" <gi...@apache.org>.
vdombrovski commented on PR #45:
URL: https://github.com/apache/cloudstack-go/pull/45#issuecomment-1402306164

   Btw I know this is out of scope as ACS 4.17 support is still drafted here https://github.com/apache/cloudstack-go/pull/38, but some repos downstream depend on this change (in my case https://github.com/kubernetes-sigs/cluster-api-provider-cloudstack)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-go] rohityadavcloud commented on pull request #45: Implement resourceiconresponse as interface{}

Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #45:
URL: https://github.com/apache/cloudstack-go/pull/45#issuecomment-1401751177

   cc @davidjumani @shwstppr can you assist?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org