You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/25 07:42:44 UTC
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7006: Allow multiple definitions as fallback in `k8sServiceNameRule`.
codecov[bot] edited a comment on pull request #7006:
URL: https://github.com/apache/skywalking/pull/7006#issuecomment-847630806
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7006](https://codecov.io/gh/apache/skywalking/pull/7006?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c0ad6e) into [master](https://codecov.io/gh/apache/skywalking/commit/32718d1d07cc3e450562ab490f25ffce1c15e70a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32718d1) will **decrease** coverage by `11.58%`.
> The diff coverage is `4.76%`.
> :exclamation: Current head 3c0ad6e differs from pull request most recent head 0685344. Consider uploading reports for the commit 0685344 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7006 +/- ##
=============================================
- Coverage 53.52% 41.93% -11.59%
+ Complexity 4260 2571 -1689
=============================================
Files 1863 827 -1036
Lines 40247 20917 -19330
Branches 4496 1996 -2500
=============================================
- Hits 21542 8772 -12770
+ Misses 17655 11439 -6216
+ Partials 1050 706 -344
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...oap/server/receiver/envoy/als/ServiceMetaInfo.java](https://codecov.io/gh/apache/skywalking/pull/7006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1NlcnZpY2VNZXRhSW5mby5qYXZh) | `100.00% <ø> (+80.00%)` | :arrow_up: |
| [...ver/receiver/envoy/als/k8s/K8SServiceRegistry.java](https://codecov.io/gh/apache/skywalking/pull/7006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOFNTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (-0.84%)` | :arrow_down: |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/7006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (-62.17%)` | :arrow_down: |
| [...r/receiver/envoy/als/k8s/ServiceNameFormatter.java](https://codecov.io/gh/apache/skywalking/pull/7006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9TZXJ2aWNlTmFtZUZvcm1hdHRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/7006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL214L01ldGFFeGNoYW5nZUFMU0hUVFBBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nvoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/7006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9rOHMvSzhzQUxTU2VydmljZU1lc2hUQ1BBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...y/als/tcp/mx/MetaExchangeTCPAccessLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/7006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL3RjcC9teC9NZXRhRXhjaGFuZ2VUQ1BBY2Nlc3NMb2dBbmFseXplci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ver/receiver/envoy/ServiceMetaInfoFactoryImpl.java](https://codecov.io/gh/apache/skywalking/pull/7006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvU2VydmljZU1ldGFJbmZvRmFjdG9yeUltcGwuamF2YQ==) | `60.00% <50.00%> (+10.00%)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/7006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1474 more](https://codecov.io/gh/apache/skywalking/pull/7006/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7006?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7006?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32718d1...0685344](https://codecov.io/gh/apache/skywalking/pull/7006?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org