You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/10/18 02:44:50 UTC
[GitHub] [inlong] vernedeng opened a new pull request, #6200: [INLONG-6103][Manager] Support update and save cluster switch info
vernedeng opened a new pull request, #6200:
URL: https://github.com/apache/inlong/pull/6200
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #6103
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6200: [INLONG-6103][Manager] Support update and save cluster switch info
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6200:
URL: https://github.com/apache/inlong/pull/6200#discussion_r999324200
##########
inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/InlongGroupEntity.java:
##########
@@ -35,6 +35,7 @@ public class InlongGroupEntity implements Serializable {
private String description;
private String mqType;
private String mqResource;
+ private String backupMqResource;
Review Comment:
It is not recommended to add special backup configurations.
You can put them in the ext_params field, or put them in the inlong_group_ext table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng closed pull request #6200: [INLONG-6103][Manager] Support update and save cluster switch info
Posted by GitBox <gi...@apache.org>.
vernedeng closed pull request #6200: [INLONG-6103][Manager] Support update and save cluster switch info
URL: https://github.com/apache/inlong/pull/6200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on pull request #6200: [INLONG-6103][Manager] Support update and save cluster switch info
Posted by GitBox <gi...@apache.org>.
vernedeng commented on PR #6200:
URL: https://github.com/apache/inlong/pull/6200#issuecomment-1291408548
cluster switch info will be saved in inlong_group_ext and inlong_stream_ext, no need to add columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on a diff in pull request #6200: [INLONG-6103][Manager] Support update and save cluster switch info
Posted by GitBox <gi...@apache.org>.
vernedeng commented on code in PR #6200:
URL: https://github.com/apache/inlong/pull/6200#discussion_r997912205
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/group/InlongGroupInfo.java:
##########
@@ -116,6 +116,12 @@ public abstract class InlongGroupInfo {
@JsonFormat(pattern = "yyyy-MM-dd HH:mm:ss")
private Date modifyTime;
+ @ApiModelProperty(value = "Backup inlong cluster tag")
+ private String backupInlongClusterTag;
Review Comment:
good suggestion, have added them to database
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #6200: [INLONG-6103][Manager] Support update and save cluster switch info
Posted by GitBox <gi...@apache.org>.
fuweng11 commented on code in PR #6200:
URL: https://github.com/apache/inlong/pull/6200#discussion_r997685743
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/group/InlongGroupInfo.java:
##########
@@ -116,6 +116,12 @@ public abstract class InlongGroupInfo {
@JsonFormat(pattern = "yyyy-MM-dd HH:mm:ss")
private Date modifyTime;
+ @ApiModelProperty(value = "Backup inlong cluster tag")
+ private String backupInlongClusterTag;
Review Comment:
If this parameter is needed in all group information, why not add a column to store it in the database instead of putting it in extParams?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org