You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/06/10 00:32:38 UTC

Review Request 35272: Removed unnecessary accessors in route code.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35272/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos


Description
-------

Removed unnecessary accessors in route code.


Diffs
-----

  src/linux/routing/link/link.cpp 6606e4a5456961e0bb0f15fcad650835b04ad2d2 
  src/linux/routing/route.hpp 933c22c9418c8f3edee37ee122334176d28374e2 
  src/linux/routing/route.cpp 87f2ed196acd17c4854a6c3162b2868f538c263a 

Diff: https://reviews.apache.org/r/35272/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 35272: Removed unnecessary accessors in route code.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35272/#review87322
-----------------------------------------------------------

Ship it!


- Ben Mahler


On June 9, 2015, 10:35 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35272/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 10:35 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accessors in route code.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/link/link.cpp 6606e4a5456961e0bb0f15fcad650835b04ad2d2 
>   src/linux/routing/route.hpp 933c22c9418c8f3edee37ee122334176d28374e2 
>   src/linux/routing/route.cpp 87f2ed196acd17c4854a6c3162b2868f538c263a 
> 
> Diff: https://reviews.apache.org/r/35272/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 35272: Removed unnecessary accessors in route code.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35272/
-----------------------------------------------------------

(Updated June 9, 2015, 10:35 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos


Description
-------

Removed unnecessary accessors in route code.


Diffs
-----

  src/linux/routing/link/link.cpp 6606e4a5456961e0bb0f15fcad650835b04ad2d2 
  src/linux/routing/route.hpp 933c22c9418c8f3edee37ee122334176d28374e2 
  src/linux/routing/route.cpp 87f2ed196acd17c4854a6c3162b2868f538c263a 

Diff: https://reviews.apache.org/r/35272/diff/


Testing
-------

make check


Thanks,

Jie Yu