You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "nabarunnag (GitHub)" <gi...@apache.org> on 2019/01/29 21:19:33 UTC
[GitHub] [geode] nabarunnag opened pull request #3135: GEODE-6333:
Adding the jetty-server dependency to geode-core.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3135 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on issue #3135: GEODE-6333:
Adding the jetty-server dependency to geode-core.
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
you probably want to have @jdeppe-pivotal and @PurelyApplied review this. I am just surprised that we have change so many files to add one dependency.
[ Full content available at: https://github.com/apache/geode/pull/3135 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] rhoughton-pivot commented on issue #3135:
GEODE-6333: Adding the jetty-server dependency to geode-core.
Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
> @PurelyApplied @rhoughton-pivot As an aside, should what's in `geode-dependencies.jar` not reflect what's in the `pom.xml`? - It currently does not.
@jdeppe-pivotal The bom/pom work for this happened while I was on leave, and I'm not sure what the correspondence between these should be. @PurelyApplied aught be better able to answer
[ Full content available at: https://github.com/apache/geode/pull/3135 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] rhoughton-pivot commented on issue #3135:
GEODE-6333: Adding the jetty-server dependency to geode-core.
Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
> @PurelyApplied and @rhoughton-pivot as the change requested are for changing jetty version in modules other than geode-core, can it be a part of a different JIRA as this just says to add jetty-server to the geode-core ?
You could punt on the Gradle clean-up, but I'd rather the clean-up and consistency work be done now instead of making more technical-debt for later.
[ Full content available at: https://github.com/apache/geode/pull/3135 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] nabarunnag closed pull request #3135: GEODE-6333:
Adding the jetty-server dependency to geode-core.
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
[ pull request closed by nabarunnag ]
[ Full content available at: https://github.com/apache/geode/pull/3135 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on issue #3135: GEODE-6333:
Adding the jetty-server dependency to geode-core.
Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
@PurelyApplied @rhoughton-pivot As an aside, should what's in `geode-dependencies.jar` not reflect what's in the `pom.xml`? - It currently does not.
[ Full content available at: https://github.com/apache/geode/pull/3135 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] nabarunnag commented on issue #3135: GEODE-6333:
Adding the jetty-server dependency to geode-core.
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
@PurelyApplied and @rhoughton-pivot as the change requested are for changing jetty version in modules other than geode-core, can it be a part of a different JIRA as this just says to add jetty-server to the geode-core ?
@jdeppe-pivotal The original issue was the inability to even start a locator. Can we make adding other jetty components a part of a different JIRA ?
[ Full content available at: https://github.com/apache/geode/pull/3135 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org