You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/12/08 02:23:22 UTC

[GitHub] [daffodil-vscode] Shanedell opened a new issue, #377: Update test suite to support daffodil-debugger

Shanedell opened a new issue, #377:
URL: https://github.com/apache/daffodil-vscode/issues/377

   Currently the test suite does not actually run the `daffodil-debugger`. We want to update the test suite to run the `daffodil-debugger` and then run tests against it, similar to how we do the `omega-edit` tests. Based on prelim looks this issue will most likely work in tandem with #301 as a lot of the code for running the `daffodil-debugger` will need to shared between the actual extension code and the suite.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [daffodil-vscode] stevedlawrence commented on issue #377: Update test suite to support daffodil-debugger

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on issue #377:
URL: https://github.com/apache/daffodil-vscode/issues/377#issuecomment-1343122040

   I don't believe that license of the png schema is compatible with ALv2.
   
   I would suggesion just make the `test.dfdl.xsd` a valid DFDL schema. I think it just needs a `dfdl:format` annotation, and maybe a couple dfdl properties defined to get it working.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [daffodil-vscode] Shanedell closed issue #377: Update test suite to support daffodil-debugger

Posted by GitBox <gi...@apache.org>.
Shanedell closed issue #377: Update test suite to support daffodil-debugger
URL: https://github.com/apache/daffodil-vscode/issues/377


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [daffodil-vscode] Shanedell commented on issue #377: Update test suite to support daffodil-debugger

Posted by GitBox <gi...@apache.org>.
Shanedell commented on issue #377:
URL: https://github.com/apache/daffodil-vscode/issues/377#issuecomment-1343370072

   @mbeckerle That is the future plan and why this needs added asap. My idea was having CI or tests clone the schemas, build them, set the necessary items and then run them through the debugger. For example doing the process you had posted for testing with pcap and ethernet, I would like to get that automated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [daffodil-vscode] Shanedell commented on issue #377: Update test suite to support daffodil-debugger

Posted by GitBox <gi...@apache.org>.
Shanedell commented on issue #377:
URL: https://github.com/apache/daffodil-vscode/issues/377#issuecomment-1343104026

   @mbeckerle @stevedlawrence I about have this solved but there is one issue I need some guidance on. So to run a schema we can't use `src/test/test.dfdl.xsd` since its not a correct schema, I had tried making one that is acceptable but still had issues. So what I did was add file `src/test/png.dfdl.xsd` from the contents found https://github.com/DFDLSchemas/PNG/blob/master/src/main/resources/com/mitre/png/xsd/png.dfdl.xsd. Then I use the png schema against our `images/daffodil.ico` file and everything worked well.
   
   Where I need guidance is if this is the way I should be doing it or would you either of you have a different preference? Also if we were to stick with png schema, do I make the rat check ignore it and then add it to the package NOTICE file with the contents of the NOTICE inside of the schema?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [daffodil-vscode] mbeckerle commented on issue #377: Update test suite to support daffodil-debugger

Posted by GitBox <gi...@apache.org>.
mbeckerle commented on issue #377:
URL: https://github.com/apache/daffodil-vscode/issues/377#issuecomment-1343332968

   Presumably to test the VSCode IDE in general we'll need a bunch of schemas allowing its functionality to be exercised in tests. Some of these schemas will need to be correct for debugger testing. Others will want to have errors in them to test authoring support such as tying diagnostics from Daffodil to the graphical presentation of those lines of the schema. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org