You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/19 14:43:12 UTC
[GitHub] [airflow] benbenbang opened a new pull request #9409: ENH: Add extra options for slack webhook operator and slack hook
benbenbang opened a new pull request #9409:
URL: https://github.com/apache/airflow/pull/9409
---
Make sure to mark the boxes below before creating PR: [x]
- [x ] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target [Github ISSUE](https://github.com/apache/airflow/issues/9407) in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] benbenbang commented on pull request #9409: Add extra options for slack webhook operator and slack hook
Posted by GitBox <gi...@apache.org>.
benbenbang commented on pull request #9409:
URL: https://github.com/apache/airflow/pull/9409#issuecomment-647515817
Hi @kaxil, @mik-laj 👋
CI Build / Core:Pg9.6,Py3.7 failed without any logs, is it bcs time out? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] benbenbang commented on pull request #9409: ENH: Add extra options for slack webhook operator and slack hook
Posted by GitBox <gi...@apache.org>.
benbenbang commented on pull request #9409:
URL: https://github.com/apache/airflow/pull/9409#issuecomment-646680600
Do I miss something here?
```
E: Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages.```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] benbenbang removed a comment on pull request #9409: Add extra options for slack webhook operator and slack hook
Posted by GitBox <gi...@apache.org>.
benbenbang removed a comment on pull request #9409:
URL: https://github.com/apache/airflow/pull/9409#issuecomment-646680600
Do I miss something here?
```
E: Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages.```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #9409: Add extra options for slack webhook operator and slack hook
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #9409:
URL: https://github.com/apache/airflow/pull/9409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9409: Add extra options for slack webhook operator and slack hook
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9409:
URL: https://github.com/apache/airflow/pull/9409#issuecomment-647516635
I have restarted CI, let's see if it passes this time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #9409: Add extra options for slack webhook operator and slack hook
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #9409:
URL: https://github.com/apache/airflow/pull/9409#discussion_r443082354
##########
File path: airflow/contrib/hooks/slack_webhook_hook.py
##########
@@ -86,6 +89,7 @@ def __init__(self,
self.icon_url = icon_url
self.link_names = link_names
self.proxy = proxy
+ self.extra_options = extra_options or dict()
Review comment:
```suggestion
self.extra_options = extra_options or {}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9409: Add extra options for slack webhook operator and slack hook
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9409:
URL: https://github.com/apache/airflow/pull/9409#issuecomment-648279148
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] benbenbang commented on pull request #9409: Add extra options for slack webhook operator and slack hook
Posted by GitBox <gi...@apache.org>.
benbenbang commented on pull request #9409:
URL: https://github.com/apache/airflow/pull/9409#issuecomment-647551231
hmmm, it failed randomly... Do you have any thoughts on this @kaxil?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org