You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2023/06/17 00:51:20 UTC
[pinot] branch master updated: Fix an integer overflow bug. (#10940)
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ce50e71d1e Fix an integer overflow bug. (#10940)
ce50e71d1e is described below
commit ce50e71d1eaf7ad9876bf812be51f0662c6d537f
Author: Shen Yu <sh...@startree.ai>
AuthorDate: Fri Jun 16 17:51:15 2023 -0700
Fix an integer overflow bug. (#10940)
---
.../query/distinct/raw/BaseRawDoubleSingleColumnDistinctExecutor.java | 2 +-
.../query/distinct/raw/BaseRawFloatSingleColumnDistinctExecutor.java | 2 +-
.../core/query/distinct/raw/BaseRawIntSingleColumnDistinctExecutor.java | 2 +-
.../query/distinct/raw/BaseRawLongSingleColumnDistinctExecutor.java | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawDoubleSingleColumnDistinctExecutor.java b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawDoubleSingleColumnDistinctExecutor.java
index 574bfe3735..452eefb170 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawDoubleSingleColumnDistinctExecutor.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawDoubleSingleColumnDistinctExecutor.java
@@ -69,7 +69,7 @@ abstract class BaseRawDoubleSingleColumnDistinctExecutor implements DistinctExec
if (_hasNull) {
records.add(new Record(new Object[]{null}));
}
- assert records.size() <= _limit + 1;
+ assert records.size() - (_hasNull ? 1 : 0) <= _limit;
return new DistinctTable(dataSchema, records, _nullHandlingEnabled);
}
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawFloatSingleColumnDistinctExecutor.java b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawFloatSingleColumnDistinctExecutor.java
index 747e591f9f..dd772a1e12 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawFloatSingleColumnDistinctExecutor.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawFloatSingleColumnDistinctExecutor.java
@@ -69,7 +69,7 @@ abstract class BaseRawFloatSingleColumnDistinctExecutor implements DistinctExecu
if (_hasNull) {
records.add(new Record(new Object[]{null}));
}
- assert records.size() <= _limit + 1;
+ assert records.size() - (_hasNull ? 1 : 0) <= _limit;
return new DistinctTable(dataSchema, records, _nullHandlingEnabled);
}
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawIntSingleColumnDistinctExecutor.java b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawIntSingleColumnDistinctExecutor.java
index c860ea0cc2..b8f87b8d56 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawIntSingleColumnDistinctExecutor.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawIntSingleColumnDistinctExecutor.java
@@ -70,7 +70,7 @@ abstract class BaseRawIntSingleColumnDistinctExecutor implements DistinctExecuto
if (_hasNull) {
records.add(new Record(new Object[]{null}));
}
- assert records.size() <= _limit + 1;
+ assert records.size() - (_hasNull ? 1 : 0) <= _limit;
return new DistinctTable(dataSchema, records, _nullHandlingEnabled);
}
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawLongSingleColumnDistinctExecutor.java b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawLongSingleColumnDistinctExecutor.java
index c721236977..eb627c74c2 100644
--- a/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawLongSingleColumnDistinctExecutor.java
+++ b/pinot-core/src/main/java/org/apache/pinot/core/query/distinct/raw/BaseRawLongSingleColumnDistinctExecutor.java
@@ -69,7 +69,7 @@ abstract class BaseRawLongSingleColumnDistinctExecutor implements DistinctExecut
if (_hasNull) {
records.add(new Record(new Object[]{null}));
}
- assert records.size() <= _limit + 1;
+ assert records.size() - (_hasNull ? 1 : 0) <= _limit;
return new DistinctTable(dataSchema, records, _nullHandlingEnabled);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org