You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Íñigo Goiri (Jira)" <ji...@apache.org> on 2020/09/15 17:23:00 UTC

[jira] [Commented] (HDFS-15579) RBF: The constructor of PathLocation may got some misunderstanding

    [ https://issues.apache.org/jira/browse/HDFS-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196406#comment-17196406 ] 

Íñigo Goiri commented on HDFS-15579:
------------------------------------

Yes, let's add a javadoc.

> RBF: The constructor of PathLocation may got some misunderstanding
> ------------------------------------------------------------------
>
>                 Key: HDFS-15579
>                 URL: https://issues.apache.org/jira/browse/HDFS-15579
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf
>            Reporter: Janus Chow
>            Priority: Minor
>
> There is a constructor of PathLocation as follows, it's for creating a new PathLocation with a prioritised nsId. 
>  
> {code:java}
> public PathLocation(PathLocation other, String firstNsId) {
>   this.sourcePath = other.sourcePath;
>   this.destOrder = other.destOrder;
>   this.destinations = orderedNamespaces(other.destinations, firstNsId);
> }
> {code}
> When I was reading the code of MultipleDestinationMountTableResolver, I thought this constructor was to create a PathLocation with an override destination. It took me a while before I realize this is a constructor to sort the destinations inside.
> Maybe I think this constructor can be more clear about its usage?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org