You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ruediger Pluem <rp...@apache.org> on 2015/10/01 20:32:22 UTC
Re: svn commit: r1703305 -
/httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
On 09/16/2015 12:20 AM, jailletc36@apache.org wrote:
> Author: jailletc36
> Date: Tue Sep 15 22:20:45 2015
> New Revision: 1703305
>
> URL: http://svn.apache.org/r1703305
> Log:
> Remove code related to 'AuthDigestEnableQueryStringHack'
>
> This has been undocumented for about 3 years now (see r1415960)
>
> Modified:
> httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
Could this cause
t/modules/digest.t
test 9 to fail?
As we removed the code for good reason we should also remove the test if this is the case then.
Regards
Rüdiger
Re: svn commit: r1703305 -
/httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
Posted by Marion & Christophe JAILLET <ch...@wanadoo.fr>.
Le 05/10/2015 12:03, Plüm, Rüdiger, Vodafone Group a écrit :
>
>> -----Original Message-----
>> From: Marion & Christophe JAILLET [mailto:christophe.jaillet@wanadoo.fr]
>> Sent: Samstag, 3. Oktober 2015 21:57
>> To: dev@httpd.apache.org
>> Subject: Re: svn commit: r1703305 -
>> /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
>>
>>
>> Le 01/10/2015 20:32, Ruediger Pluem a écrit :
>>> On 09/16/2015 12:20 AM, jailletc36@apache.org wrote:
>>>> Author: jailletc36
>>>> Date: Tue Sep 15 22:20:45 2015
>>>> New Revision: 1703305
>>>>
>>>> URL: http://svn.apache.org/r1703305
>>>> Log:
>>>> Remove code related to 'AuthDigestEnableQueryStringHack'
>>>>
>>>> This has been undocumented for about 3 years now (see r1415960)
>>>>
>>>> Modified:
>>>> httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
>>> Could this cause
>>>
>>> t/modules/digest.t
>>>
>>> test 9 to fail?
>>>
>>> As we removed the code for good reason we should also remove the test if
>> this is the case then.
>>> Regards
>>>
>>> Rüdiger
>> Hi,
>> yes, you are right.
>>
>> I would proposed the below patch:
> +1
>
>
> Regards
>
> Rüdiger
>
Done in r1706952
CJ
RE: svn commit: r1703305 -
/httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
Posted by Plüm,
Rüdiger,
Vodafone Group <ru...@vodafone.com>.
> -----Original Message-----
> From: Marion & Christophe JAILLET [mailto:christophe.jaillet@wanadoo.fr]
> Sent: Samstag, 3. Oktober 2015 21:57
> To: dev@httpd.apache.org
> Subject: Re: svn commit: r1703305 -
> /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
>
>
> Le 01/10/2015 20:32, Ruediger Pluem a écrit :
> > On 09/16/2015 12:20 AM, jailletc36@apache.org wrote:
> >> Author: jailletc36
> >> Date: Tue Sep 15 22:20:45 2015
> >> New Revision: 1703305
> >>
> >> URL: http://svn.apache.org/r1703305
> >> Log:
> >> Remove code related to 'AuthDigestEnableQueryStringHack'
> >>
> >> This has been undocumented for about 3 years now (see r1415960)
> >>
> >> Modified:
> >> httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
> > Could this cause
> >
> > t/modules/digest.t
> >
> > test 9 to fail?
> >
> > As we removed the code for good reason we should also remove the test if
> this is the case then.
> >
> > Regards
> >
> > Rüdiger
>
> Hi,
> yes, you are right.
>
> I would proposed the below patch:
+1
Regards
Rüdiger
Re: svn commit: r1703305 -
/httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
Posted by Marion & Christophe JAILLET <ch...@wanadoo.fr>.
Le 01/10/2015 20:32, Ruediger Pluem a écrit :
> On 09/16/2015 12:20 AM, jailletc36@apache.org wrote:
>> Author: jailletc36
>> Date: Tue Sep 15 22:20:45 2015
>> New Revision: 1703305
>>
>> URL: http://svn.apache.org/r1703305
>> Log:
>> Remove code related to 'AuthDigestEnableQueryStringHack'
>>
>> This has been undocumented for about 3 years now (see r1415960)
>>
>> Modified:
>> httpd/httpd/trunk/modules/aaa/mod_auth_digest.c
> Could this cause
>
> t/modules/digest.t
>
> test 9 to fail?
>
> As we removed the code for good reason we should also remove the test if this is the case then.
>
> Regards
>
> Rüdiger
Hi,
yes, you are right.
I would proposed the below patch:
Index: t/modules/digest.t
===================================================================
--- t/modules/digest.t (révision 1706466)
+++ t/modules/digest.t (copie de travail)
@@ -111,14 +111,20 @@
# finally, the MSIE tests
{
- # fake current MSIE behavior - this should work as of 2.0.51
- my $response = GET "$url?$query",
- Authorization => $no_query_auth,
- 'X-Browser' => 'MSIE';
-
- ok t_cmp($response->code,
- 200,
- 'manual Authorization with no query string in header + MSIE');
+ if (have_min_apache_version("2.5.0")) {
+ skip "'AuthDigestEnableQueryStringHack' has been removed in r1703305";
+ }
+ else
+ {
+ # fake current MSIE behavior - this should work as of 2.0.51
+ my $response = GET "$url?$query",
+ Authorization => $no_query_auth,
+ 'X-Browser' => 'MSIE';
+
+ ok t_cmp($response->code,
+ 200,
+ 'manual Authorization with no query string in header + MSIE');
+ }
}
{
This way, the test would still be done on 2.4.x where
AuthDigestEnableQueryStringHack is still present, but not on trunk where
I've removed it.
As I've never modified the test framework itself, please let me know if
it is the correct way to do?
Best regards,
CJ