You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/05/16 21:21:31 UTC

[kudu-CR] KUDU-2427: update breakpad to latest HEAD 

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10427

to review the following change.


Change subject: KUDU-2427: update breakpad to latest HEAD
......................................................................

KUDU-2427: update breakpad to latest HEAD

It includes a commit that fixes breakpad compilation with a modern gcc, such
as the one found in Ubuntu 18.04.

Change-Id: I83de57c6308605f75a447e6ef908b1335d7c4de3
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/10427/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83de57c6308605f75a447e6ef908b1335d7c4de3
Gerrit-Change-Number: 10427
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-2427: update breakpad to latest HEAD

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10427 )

Change subject: KUDU-2427: update breakpad to latest HEAD
......................................................................


Patch Set 2: Code-Review+2

Hopefully, the new version compiles without issues with older compilers.


-- 
To view, visit http://gerrit.cloudera.org:8080/10427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83de57c6308605f75a447e6ef908b1335d7c4de3
Gerrit-Change-Number: 10427
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 17 May 2018 17:25:00 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2427: update breakpad to latest HEAD

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10427 )

Change subject: KUDU-2427: update breakpad to latest HEAD
......................................................................

KUDU-2427: update breakpad to latest HEAD

It includes a commit that fixes breakpad compilation with a modern gcc, such
as the one found in Ubuntu 18.04.

Change-Id: I83de57c6308605f75a447e6ef908b1335d7c4de3
Reviewed-on: http://gerrit.cloudera.org:8080/10427
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M thirdparty/vars.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/10427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I83de57c6308605f75a447e6ef908b1335d7c4de3
Gerrit-Change-Number: 10427
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>