You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2023/01/25 21:24:35 UTC
[GitHub] [arrow] assignUser commented on a diff in pull request #14561: GH-20484: [Swift] Initial Arrow implementation
assignUser commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1087189458
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,79 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
Review Comment:
this seems a bit broad to me, in the interest of being conservative with our usage of the common apache runners I think being more specific here would be good
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,79 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
Review Comment:
```suggestion
```
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,79 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: AMD 64 Ubuntu 20.04 Swift 5.7
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 15
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ubuntu-20.04-swift-${{ hashFiles('swift/**') }}
+ restore-keys: ubuntu-20.04-swift-
Review Comment:
Is this actually needed? Does swift cache anything in one of the applicable volumes like the c++ builds do with ccache?
##########
docker-compose.yml:
##########
@@ -869,6 +870,25 @@ services:
volumes: *ubuntu-volumes
command: *python-command
+ ubuntu-swift:
+ # Usage:
+ # docker-compose build ubuntu-swift
+ # docker-compose run --rm ubuntu-swift
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # UBUNTU: 20.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-swift
+ build:
+ context: .
+ dockerfile: ci/docker/ubuntu-${UBUNTU}-swift.dockerfile
+ shm_size: *shm-size
+ environment:
+ <<: *ccache
Review Comment:
Is this needed?
##########
swift/Arrow/Package.swift:
##########
@@ -0,0 +1,23 @@
+// swift-tools-version:5.5
+// The swift-tools-version declares the minimum version of Swift required to build this package.
+
+import PackageDescription
+
+let package = Package(
Review Comment:
@abandy I am not familar with swift how is it distributed? Are the binary artifacts that need to be built and distributed or is it more in line with go where a github tag is the only thing required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org