You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2023/04/18 08:31:11 UTC
[GitHub] [superset] villebro opened a new pull request, #23720: feat(sqllab): add headers when copying results to clipboard
villebro opened a new pull request, #23720:
URL: https://github.com/apache/superset/pull/23720
### SUMMARY
When copying SQL Lab results from the query history to the clipboard, the headers are not included in the payload. This PR adds the headers.
### AFTER
Now when you copy this:
<img width="885" alt="image" src="https://user-images.githubusercontent.com/33317356/232719283-ef009167-4ac6-4a8b-992e-bab757711113.png">
You get this (the headers may appear to be off, but it's because they're tab separated, which isn't reflected in the code block):
```
ds gender name num state num_boys num_girls
1965-01-01 00:00:00.000000 boy Aaron 369 CA 369 0
1965-01-01 00:00:00.000000 girl Amy 494 CA 0 494
1965-01-01 00:00:00.000000 girl Andrea 607 CA 0 607
1965-01-01 00:00:00.000000 boy Andrew 933 CA 933 0
1965-01-01 00:00:00.000000 girl Angela 1066 CA 0 1066
1965-01-01 00:00:00.000000 girl Anna 564 CA 0 564
1965-01-01 00:00:00.000000 boy Anthony 1928 CA 1928 0
1965-01-01 00:00:00.000000 girl Barbara 922 CA 0 922
1965-01-01 00:00:00.000000 boy Bradley 395 CA 395 0
1965-01-01 00:00:00.000000 girl Brenda 961 CA 0 961
```
### BEFORE
Previously you got this:
```
1965-01-01 00:00:00.000000 boy Aaron 369 CA 369 0
1965-01-01 00:00:00.000000 girl Amy 494 CA 0 494
1965-01-01 00:00:00.000000 girl Andrea 607 CA 0 607
1965-01-01 00:00:00.000000 boy Andrew 933 CA 933 0
1965-01-01 00:00:00.000000 girl Angela 1066 CA 0 1066
1965-01-01 00:00:00.000000 girl Anna 564 CA 0 564
1965-01-01 00:00:00.000000 boy Anthony 1928 CA 1928 0
1965-01-01 00:00:00.000000 girl Barbara 922 CA 0 922
1965-01-01 00:00:00.000000 boy Bradley 395 CA 395 0
1965-01-01 00:00:00.000000 girl Brenda 961 CA 0 961
```
### TESTING INSTRUCTIONS
1. Run a query in SQL Lab
2. Go to Query History
3. Click "View" results
4. Click "Copy to clipboard"
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23720: feat(sqllab): add headers when copying results to clipboard
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23720:
URL: https://github.com/apache/superset/pull/23720#issuecomment-1513415268
## [Codecov](https://codecov.io/gh/apache/superset/pull/23720?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23720](https://codecov.io/gh/apache/superset/pull/23720?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95d854b) into [master](https://codecov.io/gh/apache/superset/commit/b39edc1002f6620b0ae71f96be3df8f9f27070bb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b39edc1) will **increase** coverage by `1.80%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 95d854b differs from pull request most recent head d431f6a. Consider uploading reports for the commit d431f6a to get more accurate results
```diff
@@ Coverage Diff @@
## master #23720 +/- ##
==========================================
+ Coverage 66.30% 68.10% +1.80%
==========================================
Files 1922 1922
Lines 74048 74047 -1
Branches 8104 8104
==========================================
+ Hits 49094 50427 +1333
+ Misses 22882 21545 -1337
- Partials 2072 2075 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.14% <75.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23720?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...s/superset-ui-core/src/components/SafeMarkdown.tsx](https://codecov.io/gh/apache/superset/pull/23720?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29tcG9uZW50cy9TYWZlTWFya2Rvd24udHN4) | `85.71% <0.00%> (+19.04%)` | :arrow_up: |
| [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/23720?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/23720?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `58.28% <ø> (+1.60%)` | :arrow_up: |
| [.../features/databases/DatabaseModal/ExtraOptions.tsx](https://codecov.io/gh/apache/superset/pull/23720?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL0V4dHJhT3B0aW9ucy50c3g=) | `70.37% <ø> (ø)` | |
| [...end/src/features/databases/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/23720?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFiYXNlcy9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `45.36% <ø> (-0.12%)` | :arrow_down: |
| [superset-frontend/src/utils/hostNamesConfig.js](https://codecov.io/gh/apache/superset/pull/23720?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2hvc3ROYW1lc0NvbmZpZy5qcw==) | `73.33% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/23720?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.86% <ø> (ø)` | |
| [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/superset/pull/23720?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | `100.00% <100.00%> (ø)` | |
... and [93 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23720/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #23720: feat(sqllab): add headers when copying results to clipboard
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #23720:
URL: https://github.com/apache/superset/pull/23720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org