You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/20 18:44:05 UTC
Review Request 55779: Passed an optional parameter by reference.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55779/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
Passed an optional parameter by reference.
Diffs
-----
src/common/protobuf_utils.hpp 6e0201953dfdaef33a6ed4039d3bbbb607e4b379
src/common/protobuf_utils.cpp 0b429267de989f09f76ddc5281890efd8bcb315e
Diff: https://reviews.apache.org/r/55779/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 55779: Passed an optional parameter by reference.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55779/#review162461
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 20, 2017, 6:44 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55779/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 6:44 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Passed an optional parameter by reference.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 6e0201953dfdaef33a6ed4039d3bbbb607e4b379
> src/common/protobuf_utils.cpp 0b429267de989f09f76ddc5281890efd8bcb315e
>
> Diff: https://reviews.apache.org/r/55779/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>