You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2014/08/28 09:14:30 UTC

svn commit: r1621065 - /pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestPDFToImage.java

Author: tilman
Date: Thu Aug 28 07:14:30 2014
New Revision: 1621065

URL: http://svn.apache.org/r1621065
Log:
PDFBOX-1695: show diff result as absolute substraction of color differences, so that minor differences will be found, but not seen

Modified:
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestPDFToImage.java

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestPDFToImage.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestPDFToImage.java?rev=1621065&r1=1621064&r2=1621065&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestPDFToImage.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestPDFToImage.java Thu Aug 28 07:14:30 2014
@@ -163,12 +163,10 @@ public class TestPDFToImage extends Test
                     {
                         bim3 = createEmptyDiffImage(minWidth, minHeight, maxWidth, maxHeight);
                     }
-                    int rgb3 = (rgb1 ^ rgb2) & 0x7f7f7f;  // 7f is to avoid colors that are too light and won't be seen
-                    if (rgb3 == 0)
-                    {
-                        rgb3 = 0x808080;
-                    }
-                    bim3.setRGB(x, y, rgb3);
+                    int r = Math.abs((rgb1 & 0xFF) - (rgb2 & 0xFF));
+                    int g = Math.abs((rgb1 & 0xFF00) - (rgb2 & 0xFF00));
+                    int b = Math.abs((rgb1 & 0xFF0000) - (rgb2 & 0xFF0000));
+                    bim3.setRGB(x, y, 0xFFFFFF - (r | g | b));
                 }
                 else
                 {