You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Gour Saha <gs...@hortonworks.com> on 2017/11/30 22:27:05 UTC

Review Request 64229: [HIVE-18037] Migrate Slider LLAP package to YARN Service framework for Hadoop 3.x

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64229/
-----------------------------------------------------------

Review request for hive and Sergey Shelukhin.


Bugs: HIVE-18037
    https://issues.apache.org/jira/browse/HIVE-18037


Repository: hive-git


Description
-------

Migrate slider based llap app-package to YARN Services in Hadoop 3.x. Log links and diagnostics will be hooked up later.


Diffs
-----

  bin/ext/llap.sh 0462d265c8 
  binary-package-licenses/README ef127e33b0 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bd25bc7cad 
  jdbc/pom.xml 8710a8bd01 
  llap-client/src/java/org/apache/hadoop/hive/llap/registry/LlapServiceInstance.java 30b1810c4e 
  llap-server/bin/llapDaemon.sh 4945473a0e 
  llap-server/changes_for_non_slider_install.txt ec20fe1a25 
  llap-server/pom.xml 176110d014 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapOptionsProcessor.java d01598c698 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 5090be2197 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapSliderUtils.java a0af554845 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapStatusServiceDriver.java 296a85136f 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java d2e93963e0 
  llap-server/src/main/resources/llap.py 26756cefe5 
  llap-server/src/main/resources/package.py 21c34e9b97 
  llap-server/src/main/resources/params.py 8972ba10d2 
  llap-server/src/main/resources/templates.py 3d747a2c5b 
  packaging/src/main/assembly/bin.xml 84686eebeb 
  pom.xml dfb29cee4b 


Diff: https://reviews.apache.org/r/64229/diff/1/


Testing
-------

Package created and successfully deployed in a Hadoop 3.0 cluster, using cmd line shell script and programatically via Java APIs.


Thanks,

Gour Saha


Re: Review Request 64229: [HIVE-18037] Migrate Slider LLAP package to YARN Service framework for Hadoop 3.x

Posted by Gour Saha <gs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64229/
-----------------------------------------------------------

(Updated Dec. 1, 2017, 12:23 a.m.)


Review request for hive and Sergey Shelukhin.


Changes
-------

returning ExitCode.SUCCESS now


Bugs: HIVE-18037
    https://issues.apache.org/jira/browse/HIVE-18037


Repository: hive-git


Description
-------

Migrate slider based llap app-package to YARN Services in Hadoop 3.x. Log links and diagnostics will be hooked up later.


Diffs (updated)
-----

  bin/ext/llap.sh 0462d265c8 
  binary-package-licenses/README ef127e33b0 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bd25bc7cad 
  jdbc/pom.xml 8710a8bd01 
  llap-client/src/java/org/apache/hadoop/hive/llap/registry/LlapServiceInstance.java 30b1810c4e 
  llap-server/bin/llapDaemon.sh 4945473a0e 
  llap-server/changes_for_non_slider_install.txt ec20fe1a25 
  llap-server/pom.xml 176110d014 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapOptionsProcessor.java d01598c698 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 5090be2197 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapSliderUtils.java a0af554845 
  llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapStatusServiceDriver.java 296a85136f 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java d2e93963e0 
  llap-server/src/main/resources/llap.py 26756cefe5 
  llap-server/src/main/resources/package.py 21c34e9b97 
  llap-server/src/main/resources/params.py 8972ba10d2 
  llap-server/src/main/resources/templates.py 3d747a2c5b 
  packaging/src/main/assembly/bin.xml 84686eebeb 
  pom.xml dfb29cee4b 


Diff: https://reviews.apache.org/r/64229/diff/2/

Changes: https://reviews.apache.org/r/64229/diff/1-2/


Testing
-------

Package created and successfully deployed in a Hadoop 3.0 cluster, using cmd line shell script and programatically via Java APIs.


Thanks,

Gour Saha


Re: Review Request 64229: [HIVE-18037] Migrate Slider LLAP package to YARN Service framework for Hadoop 3.x

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64229/#review192394
-----------------------------------------------------------




llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapStatusServiceDriver.java
Line 410 (original), 340 (patched)
<https://reviews.apache.org/r/64229/#comment270502>

    need a followup jira



llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapStatusServiceDriver.java
Line 467 (original)
<https://reviews.apache.org/r/64229/#comment270504>

    need jira to restore this code (or equivalent) based on YARN services... without it, LLAP status cannot succeed and e.g. Ambari cannot start LLAP


- Sergey Shelukhin


On Nov. 30, 2017, 10:27 p.m., Gour Saha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64229/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2017, 10:27 p.m.)
> 
> 
> Review request for hive and Sergey Shelukhin.
> 
> 
> Bugs: HIVE-18037
>     https://issues.apache.org/jira/browse/HIVE-18037
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Migrate slider based llap app-package to YARN Services in Hadoop 3.x. Log links and diagnostics will be hooked up later.
> 
> 
> Diffs
> -----
> 
>   bin/ext/llap.sh 0462d265c8 
>   binary-package-licenses/README ef127e33b0 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java bd25bc7cad 
>   jdbc/pom.xml 8710a8bd01 
>   llap-client/src/java/org/apache/hadoop/hive/llap/registry/LlapServiceInstance.java 30b1810c4e 
>   llap-server/bin/llapDaemon.sh 4945473a0e 
>   llap-server/changes_for_non_slider_install.txt ec20fe1a25 
>   llap-server/pom.xml 176110d014 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapOptionsProcessor.java d01598c698 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 5090be2197 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapSliderUtils.java a0af554845 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapStatusServiceDriver.java 296a85136f 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java d2e93963e0 
>   llap-server/src/main/resources/llap.py 26756cefe5 
>   llap-server/src/main/resources/package.py 21c34e9b97 
>   llap-server/src/main/resources/params.py 8972ba10d2 
>   llap-server/src/main/resources/templates.py 3d747a2c5b 
>   packaging/src/main/assembly/bin.xml 84686eebeb 
>   pom.xml dfb29cee4b 
> 
> 
> Diff: https://reviews.apache.org/r/64229/diff/1/
> 
> 
> Testing
> -------
> 
> Package created and successfully deployed in a Hadoop 3.0 cluster, using cmd line shell script and programatically via Java APIs.
> 
> 
> Thanks,
> 
> Gour Saha
> 
>