[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1204: [feat] add tag sync func and ut when db mode is etcd

[GitBox <gi...@apache.org>]

tianxiaoliang commented on a change in pull request #1204:
URL: https://github.com/apache/servicecomb-service-center/pull/1204#discussion_r779483865



##########
File path: datasource/etcd/account.go
##########
@@ -84,7 +85,13 @@ func (ds *RbacDAO) CreateAccount(ctx context.Context, a *rbacmodel.Account) erro
 		return err
 	}
 	if datasource.EnableSync {
-		op, err := GenTaskOpts("", "", sync.CreateAction, datasource.ResourceAccount, a)
+		op, err := eutil.GenTaskOpts(&eutil.TaskOpt{
+			Domain:       "",

Review comment:
       空是不必写出来的

##########
File path: datasource/etcd/account.go
##########
@@ -195,12 +202,18 @@ func (ds *RbacDAO) DeleteAccount(ctx context.Context, names []string) (bool, err
 
 		}
 		if datasource.EnableSync {
-			taskOpt, err := GenTaskOpts("", "", sync.DeleteAction, datasource.ResourceAccount, a)
+			taskOpt, err := eutil.GenTaskOpts(&eutil.TaskOpt{
+				Domain:       "",

Review comment:
       删

##########
File path: datasource/etcd/account.go
##########
@@ -248,7 +261,13 @@ func (ds *RbacDAO) UpdateAccount(ctx context.Context, name string, account *rbac
 		opts = append(opts, opt)
 	}
 	if datasource.EnableSync {
-		op, err := GenTaskOpts("", "", sync.UpdateAction, datasource.ResourceAccount, account)
+		op, err := eutil.GenTaskOpts(&eutil.TaskOpt{
+			Domain:       "",

Review comment:
       删除




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org