You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by el...@apache.org on 2026/08/05 22:29:24 UTC
(maven-archiver) branch master updated: [MSHARED-815] Pattern.compile() called on every invocation of handleSpecificationEntries (#377)
This is an automated email from the ASF dual-hosted git repository.
elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-archiver.git
The following commit(s) were added to refs/heads/master by this push:
new e18b36c [MSHARED-815] Pattern.compile() called on every invocation of handleSpecificationEntries (#377)
e18b36c is described below
commit e18b36ca13795b8e42fcd42aa4bacb3bc2998380
Author: Elliotte Rusty Harold <el...@users.noreply.github.com>
AuthorDate: Wed Aug 5 22:29:18 2026 +0000
[MSHARED-815] Pattern.compile() called on every invocation of handleSpecificationEntries (#377)
* Extract Pattern.compile() to static final field
* Apply spotless formatting
---
src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java b/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java
index 63a4ca5..7e865d4 100644
--- a/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java
+++ b/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java
@@ -99,6 +99,8 @@ public class MavenArchiver {
private static final List<String> ARTIFACT_EXPRESSION_PREFIXES;
+ private static final Pattern SPECIFICATION_VERSION_PATTERN = Pattern.compile("([0-9]+\\.[0-9]+)(.*?)");
+
static {
List<String> artifactExpressionPrefixes = new ArrayList<>();
artifactExpressionPrefixes.add("artifact.");
@@ -414,7 +416,7 @@ public class MavenArchiver {
m, entries, "Specification-Title", project.getModel().getName());
String version = project.getPomArtifact().getVersion().toString();
- Matcher matcher = Pattern.compile("([0-9]+\\.[0-9]+)(.*?)").matcher(version);
+ Matcher matcher = SPECIFICATION_VERSION_PATTERN.matcher(version);
if (matcher.matches()) {
String specVersion = matcher.group(1);
addManifestAttribute(m, entries, "Specification-Version", specVersion);