[GitHub] [incubator-opendal] ClSlaid commented on a diff in pull request #1649: chore(automation): fix release.sh packaging sha512sum

["ClSlaid (via GitHub)" <gi...@apache.org>]

ClSlaid commented on code in PR #1649:
URL: https://github.com/apache/incubator-opendal/pull/1649#discussion_r1138670437


##########
scripts/release.sh:
##########
@@ -37,18 +36,32 @@ rm -rf dist
 mkdir -p dist/
 
 echo "> Checkout version branch"
-git checkout -B $git_branch
+git checkout -B "${git_branch}"
 
 echo "> Start package"
-git archive --format=tar.gz --output="dist/apache-incubator-opendal-$release_version-src.tar.gz" --prefix="apache-incubator-opendal-$release_version-src/"  $git_branch
+git archive --format=tar.gz --output="dist/apache-incubator-opendal-$release_version-src.tar.gz" --prefix="apache-incubator-opendal-$release_version-src/" "$git_branch"
+
+cd dist
 
 echo "> Generate signature"
-for i in dist/*.tar.gz; do echo $i; gpg --armor --output $i.asc --detach-sig $i ; done
+for i in *.tar.gz; do
+	echo "$i"
+	gpg --armor --output "$i.asc" --detach-sig "$i"
+done
 echo "> Check signature"
-for i in dist/*.tar.gz; do echo $i; gpg --verify $i.asc $i ; done
+for i in *.tar.gz; do
+	echo "$i"
+	gpg --verify "$i.asc" "$i"
+done
 echo "> Generate sha512sum"
-for i in dist/*.tar.gz; do echo $i; sha512sum $i > $i.sha512 ; done
+for i in *.tar.gz; do
+	echo "$i"
+	sha512sum "$i" >"$i.sha512"
+done
 echo "> Check sha512sum"
-for i in dist/*.tar.gz; do echo $i; sha512sum --check $i.sha512; done
+for i in *.tar.gz; do
+	echo "$i"
+	sha512sum --check "$i.sha512"
+done
 echo "> Check license"
-docker run -it --rm -v $(pwd):/github/workspace -u $(id -u):$(id -g) ghcr.io/korandoru/hawkeye-native check
+docker run -it --rm -v "$(pwd):/github/workspace" -u "$(id -u):$(id -g)" ghcr.io/korandoru/hawkeye-native check

Review Comment:
   I think so.🤔️



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org