You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/12 13:49:57 UTC

[GitHub] [apisix] gxthrj commented on a change in pull request #4208: feat: support passing different host headers in multiple nodes

gxthrj commented on a change in pull request #4208:
URL: https://github.com/apache/apisix/pull/4208#discussion_r631055257



##########
File path: apisix/balancer.lua
##########
@@ -134,6 +145,30 @@ local function pick_server(route, ctx)
         end
     end
 
+    local retries = up_conf.retries
+    if not retries or retries < 0 then
+        retries = #up_conf.nodes - 1

Review comment:
       Is it possible that nodes have a length of 0 ？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org