You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/24 12:07:45 UTC
[GitHub] [hadoop-ozone] fapifta commented on issue #701: HDDS-2691. Ozone
Shell code cleanup
fapifta commented on issue #701: HDDS-2691. Ozone Shell code cleanup
URL: https://github.com/apache/hadoop-ozone/pull/701#issuecomment-603201449
Hi Attila, thank you for the great work and simplification done here.
The changes looks great, in general I do not see any issues with it, though I left some comments inline to discuss a few questions, and suggest some changes. All of them are minor stuff, except the one about the getAddress method in ACLHandler implementations which should be pulled up to the base abstract ACLHandler class as all of them are the same effectively duplicating code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org