You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org> on 2011/07/01 18:42:28 UTC
[jira] [Created] (WICKET-3856) Relax wicket:enclosure warning
suggesting the usage of EnclosureContainer
Relax wicket:enclosure warning suggesting the usage of EnclosureContainer
-------------------------------------------------------------------------
Key: WICKET-3856
URL: https://issues.apache.org/jira/browse/WICKET-3856
Project: Wicket
Issue Type: Improvement
Components: wicket-core
Reporter: Adriano dos Santos Fernandes
Sometime in 1.4, wicket:enclosure got some diagnostics warnings about FormComponents and EnclosureContainer was added.
wicket:enclosure has two usages:
---------------
1) Hide some content based on its own child components, i.e.:
<wicket:enclosure child="x">
<div>
........
<input wicket:id="x" />
</div>
</wicket:enclosure>
2) Hide content based on non-child components, i.e.:
<wicket:enclosure child="x">
........
</wicket:enclosure>
<input wicket:id="x" />
---------------
It's safe to relax the warning for the case (1), when the only FormComponent child is equal to the "wicket:enclosure child" attribute.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3856) Relax wicket:enclosure warning
suggesting the usage of EnclosureContainer
Posted by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059107#comment-13059107 ]
Adriano dos Santos Fernandes commented on WICKET-3856:
------------------------------------------------------
Are you going to fix it in 1.5-RC6 too?
> Relax wicket:enclosure warning suggesting the usage of EnclosureContainer
> -------------------------------------------------------------------------
>
> Key: WICKET-3856
> URL: https://issues.apache.org/jira/browse/WICKET-3856
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.4.18
>
>
> Sometime in 1.4, wicket:enclosure got some diagnostics warnings about FormComponents and EnclosureContainer was added.
> wicket:enclosure has two usages:
> ---------------
> 1) Hide some content based on its own child components, i.e.:
> <wicket:enclosure child="x">
> <div>
> ........
> <input wicket:id="x" />
> </div>
> </wicket:enclosure>
> 2) Hide content based on non-child components, i.e.:
> <wicket:enclosure child="x">
> ........
> </wicket:enclosure>
> <input wicket:id="x" />
> ---------------
> It's safe to relax the warning for the case (1), when the only FormComponent child is equal to the "wicket:enclosure child" attribute.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3856) Relax wicket:enclosure warning
suggesting the usage of EnclosureContainer
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059110#comment-13059110 ]
Juergen Donnerstag commented on WICKET-3856:
--------------------------------------------
It shouldn't exist in 1.5 trunk. Please test.
> Relax wicket:enclosure warning suggesting the usage of EnclosureContainer
> -------------------------------------------------------------------------
>
> Key: WICKET-3856
> URL: https://issues.apache.org/jira/browse/WICKET-3856
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.4.18
>
>
> Sometime in 1.4, wicket:enclosure got some diagnostics warnings about FormComponents and EnclosureContainer was added.
> wicket:enclosure has two usages:
> ---------------
> 1) Hide some content based on its own child components, i.e.:
> <wicket:enclosure child="x">
> <div>
> ........
> <input wicket:id="x" />
> </div>
> </wicket:enclosure>
> 2) Hide content based on non-child components, i.e.:
> <wicket:enclosure child="x">
> ........
> </wicket:enclosure>
> <input wicket:id="x" />
> ---------------
> It's safe to relax the warning for the case (1), when the only FormComponent child is equal to the "wicket:enclosure child" attribute.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3856) Relax wicket:enclosure warning
suggesting the usage of EnclosureContainer
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059133#comment-13059133 ]
Juergen Donnerstag commented on WICKET-3856:
--------------------------------------------
sorry. The patch has been attached to WICKET-3789, but I did not commit it yet. Will do so soon.
> Relax wicket:enclosure warning suggesting the usage of EnclosureContainer
> -------------------------------------------------------------------------
>
> Key: WICKET-3856
> URL: https://issues.apache.org/jira/browse/WICKET-3856
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.4.18
>
>
> Sometime in 1.4, wicket:enclosure got some diagnostics warnings about FormComponents and EnclosureContainer was added.
> wicket:enclosure has two usages:
> ---------------
> 1) Hide some content based on its own child components, i.e.:
> <wicket:enclosure child="x">
> <div>
> ........
> <input wicket:id="x" />
> </div>
> </wicket:enclosure>
> 2) Hide content based on non-child components, i.e.:
> <wicket:enclosure child="x">
> ........
> </wicket:enclosure>
> <input wicket:id="x" />
> ---------------
> It's safe to relax the warning for the case (1), when the only FormComponent child is equal to the "wicket:enclosure child" attribute.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-3856) Relax wicket:enclosure warning
suggesting the usage of EnclosureContainer
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-3856:
-------------------------------------
Assignee: Igor Vaynberg
> Relax wicket:enclosure warning suggesting the usage of EnclosureContainer
> -------------------------------------------------------------------------
>
> Key: WICKET-3856
> URL: https://issues.apache.org/jira/browse/WICKET-3856
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
>
> Sometime in 1.4, wicket:enclosure got some diagnostics warnings about FormComponents and EnclosureContainer was added.
> wicket:enclosure has two usages:
> ---------------
> 1) Hide some content based on its own child components, i.e.:
> <wicket:enclosure child="x">
> <div>
> ........
> <input wicket:id="x" />
> </div>
> </wicket:enclosure>
> 2) Hide content based on non-child components, i.e.:
> <wicket:enclosure child="x">
> ........
> </wicket:enclosure>
> <input wicket:id="x" />
> ---------------
> It's safe to relax the warning for the case (1), when the only FormComponent child is equal to the "wicket:enclosure child" attribute.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3856) Relax wicket:enclosure warning
suggesting the usage of EnclosureContainer
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3856.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4.18
> Relax wicket:enclosure warning suggesting the usage of EnclosureContainer
> -------------------------------------------------------------------------
>
> Key: WICKET-3856
> URL: https://issues.apache.org/jira/browse/WICKET-3856
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.4.18
>
>
> Sometime in 1.4, wicket:enclosure got some diagnostics warnings about FormComponents and EnclosureContainer was added.
> wicket:enclosure has two usages:
> ---------------
> 1) Hide some content based on its own child components, i.e.:
> <wicket:enclosure child="x">
> <div>
> ........
> <input wicket:id="x" />
> </div>
> </wicket:enclosure>
> 2) Hide content based on non-child components, i.e.:
> <wicket:enclosure child="x">
> ........
> </wicket:enclosure>
> <input wicket:id="x" />
> ---------------
> It's safe to relax the warning for the case (1), when the only FormComponent child is equal to the "wicket:enclosure child" attribute.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3856) Relax wicket:enclosure warning
suggesting the usage of EnclosureContainer
Posted by "Adriano dos Santos Fernandes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059113#comment-13059113 ]
Adriano dos Santos Fernandes commented on WICKET-3856:
------------------------------------------------------
Was it fixed in some other way?
The issue is present in 1.5-RC5.1, and I don't see the same commit in trunk's Enclosure.java.
> Relax wicket:enclosure warning suggesting the usage of EnclosureContainer
> -------------------------------------------------------------------------
>
> Key: WICKET-3856
> URL: https://issues.apache.org/jira/browse/WICKET-3856
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.4.18
>
>
> Sometime in 1.4, wicket:enclosure got some diagnostics warnings about FormComponents and EnclosureContainer was added.
> wicket:enclosure has two usages:
> ---------------
> 1) Hide some content based on its own child components, i.e.:
> <wicket:enclosure child="x">
> <div>
> ........
> <input wicket:id="x" />
> </div>
> </wicket:enclosure>
> 2) Hide content based on non-child components, i.e.:
> <wicket:enclosure child="x">
> ........
> </wicket:enclosure>
> <input wicket:id="x" />
> ---------------
> It's safe to relax the warning for the case (1), when the only FormComponent child is equal to the "wicket:enclosure child" attribute.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3856) Relax wicket:enclosure warning
suggesting the usage of EnclosureContainer
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059120#comment-13059120 ]
Juergen Donnerstag commented on WICKET-3856:
--------------------------------------------
yes
> Relax wicket:enclosure warning suggesting the usage of EnclosureContainer
> -------------------------------------------------------------------------
>
> Key: WICKET-3856
> URL: https://issues.apache.org/jira/browse/WICKET-3856
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Reporter: Adriano dos Santos Fernandes
> Assignee: Igor Vaynberg
> Fix For: 1.4.18
>
>
> Sometime in 1.4, wicket:enclosure got some diagnostics warnings about FormComponents and EnclosureContainer was added.
> wicket:enclosure has two usages:
> ---------------
> 1) Hide some content based on its own child components, i.e.:
> <wicket:enclosure child="x">
> <div>
> ........
> <input wicket:id="x" />
> </div>
> </wicket:enclosure>
> 2) Hide content based on non-child components, i.e.:
> <wicket:enclosure child="x">
> ........
> </wicket:enclosure>
> <input wicket:id="x" />
> ---------------
> It's safe to relax the warning for the case (1), when the only FormComponent child is equal to the "wicket:enclosure child" attribute.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira