You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2026/01/13 19:40:03 UTC
[PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
voonhous opened a new pull request, #17845:
URL: https://github.com/apache/hudi/pull/17845
… pruning
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the changes
(or) link to an issue by including `Closes #<issue-number>` for context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
`AvroSchemaUtils.pruneDataSchema` was stripping `logicalType` and metadata during schema reconstruction. This breaks the new Variant feature implementation (which uses `logicalType: "variant"`), which relies on the `logicalType` field to correctly determine that a field is a `Variant` type.
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in behavior.
Followed by a detailed log of all the changes. Highlight if any code was copied. -->
Users now retain correct schema metadata after pruning operations.
* **Fix:** Updated `pruneDataSchemaInternal` to explicitly copy object properties and `logicalType` when reconstructing Records, Arrays, and Maps.
### Impact
<!-- Describe any public API or user-facing feature change or any performance impact. -->
* **Critical:** Enables the new Variant data type.
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk.
If medium or high, explain what verification was done to mitigate the risks. -->
Low. Verifies that standard Avro properties are carried over during reconstruction.
### Documentation Update
<!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website. Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
none
### Contributor's checklist
- [X] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3747467618
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982",
"triggerID" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"triggerType" : "PUSH"
}, {
"hash" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11014",
"triggerID" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"triggerType" : "PUSH"
}, {
"hash" : "68dd893d849dc7b246faea6dc6ee822a07c96bcc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "68dd893d849dc7b246faea6dc6ee822a07c96bcc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a661fb2271e09456705c52b904232b8e3ee4b1fc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982)
* dea5d72eefef1fec48d9dbdabfe63c8ebf845010 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11014)
* 68dd893d849dc7b246faea6dc6ee822a07c96bcc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3747952408
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e590ecb39f77261f88857667f0dac58ff707c1a2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11021",
"triggerID" : "e590ecb39f77261f88857667f0dac58ff707c1a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e590ecb39f77261f88857667f0dac58ff707c1a2 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11021)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3747617288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982",
"triggerID" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"triggerType" : "PUSH"
}, {
"hash" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11014",
"triggerID" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"triggerType" : "PUSH"
}, {
"hash" : "68dd893d849dc7b246faea6dc6ee822a07c96bcc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11017",
"triggerID" : "68dd893d849dc7b246faea6dc6ee822a07c96bcc",
"triggerType" : "PUSH"
}, {
"hash" : "e590ecb39f77261f88857667f0dac58ff707c1a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e590ecb39f77261f88857667f0dac58ff707c1a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a661fb2271e09456705c52b904232b8e3ee4b1fc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982)
* dea5d72eefef1fec48d9dbdabfe63c8ebf845010 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11014)
* 68dd893d849dc7b246faea6dc6ee822a07c96bcc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11017)
* e590ecb39f77261f88857667f0dac58ff707c1a2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3747414504
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982",
"triggerID" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"triggerType" : "PUSH"
}, {
"hash" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a661fb2271e09456705c52b904232b8e3ee4b1fc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982)
* dea5d72eefef1fec48d9dbdabfe63c8ebf845010 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3747419070
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982",
"triggerID" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"triggerType" : "PUSH"
}, {
"hash" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11014",
"triggerID" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a661fb2271e09456705c52b904232b8e3ee4b1fc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982)
* dea5d72eefef1fec48d9dbdabfe63c8ebf845010 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11014)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3747805996
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982",
"triggerID" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"triggerType" : "PUSH"
}, {
"hash" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11014",
"triggerID" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"triggerType" : "PUSH"
}, {
"hash" : "68dd893d849dc7b246faea6dc6ee822a07c96bcc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11017",
"triggerID" : "68dd893d849dc7b246faea6dc6ee822a07c96bcc",
"triggerType" : "PUSH"
}, {
"hash" : "e590ecb39f77261f88857667f0dac58ff707c1a2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11021",
"triggerID" : "e590ecb39f77261f88857667f0dac58ff707c1a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 68dd893d849dc7b246faea6dc6ee822a07c96bcc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11017)
* e590ecb39f77261f88857667f0dac58ff707c1a2 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11021)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3747660034
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982",
"triggerID" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"triggerType" : "PUSH"
}, {
"hash" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11014",
"triggerID" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"triggerType" : "PUSH"
}, {
"hash" : "68dd893d849dc7b246faea6dc6ee822a07c96bcc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11017",
"triggerID" : "68dd893d849dc7b246faea6dc6ee822a07c96bcc",
"triggerType" : "PUSH"
}, {
"hash" : "e590ecb39f77261f88857667f0dac58ff707c1a2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11021",
"triggerID" : "e590ecb39f77261f88857667f0dac58ff707c1a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dea5d72eefef1fec48d9dbdabfe63c8ebf845010 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11014)
* 68dd893d849dc7b246faea6dc6ee822a07c96bcc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11017)
* e590ecb39f77261f88857667f0dac58ff707c1a2 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11021)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous merged PR #17845:
URL: https://github.com/apache/hudi/pull/17845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3746172714
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a661fb2271e09456705c52b904232b8e3ee4b1fc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #17845:
URL: https://github.com/apache/hudi/pull/17845#discussion_r2688763373
##########
hudi-common/src/test/java/org/apache/hudi/common/schema/TestHoodieSchemaUtils.java:
##########
@@ -1759,4 +1759,19 @@ void testResolveUnionSchemaWithPrimitiveTypes() {
HoodieSchema result = HoodieSchemaUtils.resolveUnionSchema(nullableString, "string");
assertEquals(HoodieSchemaType.STRING, result.getType());
}
+
+ @Test
+ void testLogicalTypesRetainedAfterPrune() {
Review Comment:
Done, added nested fields and also fields that have logicalTypes like timestampMicros + uuid in a separate test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3747535253
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982",
"triggerID" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"triggerType" : "PUSH"
}, {
"hash" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11014",
"triggerID" : "dea5d72eefef1fec48d9dbdabfe63c8ebf845010",
"triggerType" : "PUSH"
}, {
"hash" : "68dd893d849dc7b246faea6dc6ee822a07c96bcc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11017",
"triggerID" : "68dd893d849dc7b246faea6dc6ee822a07c96bcc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a661fb2271e09456705c52b904232b8e3ee4b1fc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982)
* dea5d72eefef1fec48d9dbdabfe63c8ebf845010 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11014)
* 68dd893d849dc7b246faea6dc6ee822a07c96bcc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11017)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3746189520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982",
"triggerID" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a661fb2271e09456705c52b904232b8e3ee4b1fc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on code in PR #17845:
URL: https://github.com/apache/hudi/pull/17845#discussion_r2688706234
##########
hudi-common/src/test/java/org/apache/hudi/common/schema/TestHoodieSchemaUtils.java:
##########
@@ -1759,4 +1759,19 @@ void testResolveUnionSchemaWithPrimitiveTypes() {
HoodieSchema result = HoodieSchemaUtils.resolveUnionSchema(nullableString, "string");
assertEquals(HoodieSchemaType.STRING, result.getType());
}
+
+ @Test
+ void testLogicalTypesRetainedAfterPrune() {
Review Comment:
Can you validate that this works on nested fields as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3746560271
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982",
"triggerID" : "a661fb2271e09456705c52b904232b8e3ee4b1fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a661fb2271e09456705c52b904232b8e3ee4b1fc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10982)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Ensure that custom logical types in records are preserved during… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17845:
URL: https://github.com/apache/hudi/pull/17845#issuecomment-3747946713
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e590ecb39f77261f88857667f0dac58ff707c1a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e590ecb39f77261f88857667f0dac58ff707c1a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e590ecb39f77261f88857667f0dac58ff707c1a2 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org