Coding Guidelines:

[Olaf Flebbe <of...@oflebbe.de>]

Hi,

I encountered two commits to master in the last month not having the JIRA ID in the subject.

May I ask to stick to convention "start commit message with JIRA ID on the first line", please ?

Best 
Olaf

Re: Coding Guidelines:

[Evans Ye <ev...@apache.org>]

Sorry. Those two are committed by me. I shall pay more attention on that.
Thank you for spotting on the issue and raise it out :)

Konstantin Boudnik <co...@apache.org> 於 2018年10月3日 週三 下午1:16寫道：

> Huge +1!
> So far, CTR worked well for us, let's not break the good flow. Thanks!
> --
>   With regards,
> Konstantin (Cos) Boudnik
> 2CAC 8312 4870 D885 8616  6115 220F 6980 1F27 E622
>
> Disclaimer: Opinions expressed in this email are those of the author,
> and do not necessarily represent the views of any company the author
> might be affiliated with at the moment of writing.
>
>
> On Tue, Oct 2, 2018 at 9:56 PM, Olaf Flebbe <of...@oflebbe.de> wrote:
> > Hi,
> >
> > I encountered two commits to master in the last month not having the
> JIRA ID in the subject.
> >
> > May I ask to stick to convention "start commit message with JIRA ID on
> the first line", please ?
> >
> > Best
> > Olaf
> >
> >
>

Re: Coding Guidelines:

[Konstantin Boudnik <co...@apache.org>]

Huge +1!
So far, CTR worked well for us, let's not break the good flow. Thanks!
--
  With regards,
Konstantin (Cos) Boudnik
2CAC 8312 4870 D885 8616  6115 220F 6980 1F27 E622

Disclaimer: Opinions expressed in this email are those of the author,
and do not necessarily represent the views of any company the author
might be affiliated with at the moment of writing.


On Tue, Oct 2, 2018 at 9:56 PM, Olaf Flebbe <of...@oflebbe.de> wrote:
> Hi,
>
> I encountered two commits to master in the last month not having the JIRA ID in the subject.
>
> May I ask to stick to convention "start commit message with JIRA ID on the first line", please ?
>
> Best
> Olaf
>
>