You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/12/06 11:51:11 UTC

[GitHub] [tinkerpop] spmallette commented on issue #1227: make Cluster be able to open file in classpath resource dir

spmallette commented on issue #1227: make Cluster be able to open file in classpath resource dir
URL: https://github.com/apache/tinkerpop/pull/1227#issuecomment-562543183
 
 
   Thanks for you contribution. A few points:
   
   1. You have targeted the master branch with this change which is 3.5.0 which has no fixed release date at this time. I think you should re-target this PR to tp33 so that it can be applied from 3.3.x forward.
   2. Please add a test for this change - perhaps just add a new test here: https://github.com/apache/tinkerpop/blob/tp33/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinDriverIntegrateTest.java
   3. Please add a CHANGELOG entry that describes your change (though I don't mind doing that myself on merge).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services