You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/17 09:00:44 UTC
[GitHub] [cloudstack] rhtyd opened a new pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
rhtyd opened a new pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025
Fixes issue of passing password and management secret key with special
characters.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842153712
Suggested test cases, run the `cloudstack-setup-databases` with DB password containing special characters such as `(` and similarly pass the db secret key and management server secret key with special characters such as `&(*`. cc @Spaceman1984 @Pearl1594 @shwstppr pl help with manual test and review.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842228072
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842748865
<b>Trillian test result (tid-699)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 54164 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5025-t699-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 79 look OK, 8 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.36 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.36 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.35 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.37 | test_templates.py
test_04_extract_template | `Failure` | 128.27 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_volume_usage | `Failure` | 787.09 | test_usage.py
test_10_attachAndDetach_iso | `Failure` | 1510.44 | test_vm_life_cycle.py
test_06_download_detached_volume | `Failure` | 311.51 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842153712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842255903
Tested LGTM - works as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842154044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842214830
<b>Trillian Build Failed (tid-700)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842182068
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842154044
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-843330054
<b>Trillian test result (tid-703)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40132 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5025-t703-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_ping_in_vr_success | `Error` | 60.36 | test_diagnostics.py
test_02_ping_in_vr_failure | `Error` | 60.19 | test_diagnostics.py
test_07_arping_in_vr | `Failure` | 5.14 | test_diagnostics.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 467.44 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 480.68 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 466.84 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842828002
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842182917
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-843326074
<b>Trillian test result (tid-701)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 104579 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5025-t701-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 62 look OK, 25 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
test_DeleteDomain | `Error` | 0.74 | test_accounts.py
test_forceDeleteDomain | `Failure` | 0.74 | test_accounts.py
test_forceDeleteDomain | `Error` | 2.85 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 4.96 | test_accounts.py
ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1514.67 | test_domain_service_offerings.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
test_01_create_iso_with_checksum_sha1 | `Error` | 65.30 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 65.31 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 65.31 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 65.41 | test_iso.py
test_01_create_iso | `Failure` | 1510.86 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3026.29 | test_iso.py
ContextSuite context=TestAsyncJob>:setup | `Error` | 0.00 | test_async_job.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
test_list_clusters_metrics | `Error` | 1512.69 | test_metrics_api.py
test_list_vms_metrics | `Error` | 0.11 | test_metrics_api.py
ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
test_delete_account | `Error` | 1511.29 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 0.04 | test_network.py
test_deploy_vm_l2network | `Error` | 0.04 | test_network.py
test_l2network_restart | `Error` | 1.11 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 3.29 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 0.93 | test_network.py
test_reboot_router | `Error` | 0.03 | test_network.py
test_releaseIP | `Error` | 0.39 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 0.43 | test_network.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_nic_secondaryip_add_remove | `Error` | 1512.00 | test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1518.24 | test_projects.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 495.87 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Failure` | 466.36 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842826351
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842255903
Tested LGTM - works as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842227295
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842227295
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5025: setup: pass password in quotes for cloudstack-setup-databases
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5025:
URL: https://github.com/apache/cloudstack/pull/5025#issuecomment-842181821
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org