You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "dkranchii (via GitHub)" <gi...@apache.org> on 2026/05/02 08:17:35 UTC

[PR] fix(tls): log transient SSL factory renewal failures at WARN instead of INFO [pinot]

dkranchii opened a new pull request, #18403:
URL: https://github.com/apache/pinot/pull/18403

   Bumps the log level from `INFO` to `WARN` in the retry catch block of
   `RenewableTlsUtils.reloadSslFactory`, so transient SSL renewal failures
   are visible to anyone monitoring at `WARN+` (which is most prod log
   pipelines).
   
   Also tightens the message: the old text ended with `"... truststore {}) on "`
   which looked truncated. The new wording stays accurate even on the
   final retry, so it doesn't contradict the `LOGGER.error` that fires
   right after when all 3 attempts fail.
   
   ### Diff
   
   ```java
   } catch (Exception e) {
   - LOGGER.info(
   + LOGGER.warn(
         "reloadSslFactory :: Encountered issues when renewing SSLFactory "
         + "{} (built from key store {} and "
   -     + "truststore {}) on ", baseSslFactory, keyStorePath, trustStorePath, e);
   +     + "truststore {}), retrying if attempts remain",
   +     baseSslFactory, keyStorePath, trustStorePath, e);
     return false;
   }
   ```
   ### Scope
   Single file: pinot-common/src/main/java/org/apache/pinot/common/utils/tls/RenewableTlsUtils.java
   No behavior change, no config / SPI / wire-format change
   
   ### Testing
   Existing RenewableTlsUtilsTest still passes (catch block isn't currently covered by a test, so no test changes needed).
   Manually verified the new message renders correctly when an exception is thrown — the SLF4J trailing Throwable argument still produces the full stack trace.
   
   ### Release note
   none (observability-only change)
   
   Fixes #18402


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] fix(tls): log transient SSL factory renewal failures at WARN instead of INFO [pinot]

Posted by "dkranchii (via GitHub)" <gi...@apache.org>.
dkranchii commented on PR #18403:
URL: https://github.com/apache/pinot/pull/18403#issuecomment-4434979567

   @yashmayya  Good call - you're right, the inner catch fires on every healthy rotation, so WARN would
   just add noise. The outer ERROR already covers the failure case we care about. Kept just the message wording fix, dropped the level change. Thanks !!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] fix(tls): log transient SSL factory renewal failures at WARN instead of INFO [pinot]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18403:
URL: https://github.com/apache/pinot/pull/18403#issuecomment-4375051293

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/18403?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 55.41%. Comparing base ([`80fb0e8`](https://app.codecov.io/gh/apache/pinot/commit/80fb0e8932aa9b1beb40df9613111667b8b5765d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a63fb42`](https://app.codecov.io/gh/apache/pinot/commit/a63fb4254d00b9e2e250c6da0a940eabd70ccd60?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 9 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/18403?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...ache/pinot/common/utils/tls/RenewableTlsUtils.java](https://app.codecov.io/gh/apache/pinot/pull/18403?src=pr&el=tree&filepath=pinot-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcommon%2Futils%2Ftls%2FRenewableTlsUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvdGxzL1JlbmV3YWJsZVRsc1V0aWxzLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/18403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (80fb0e8) and HEAD (a63fb42). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (80fb0e8) | HEAD (a63fb42) |
   >|------|------|------|
   >|java-21|5|1|
   >|unittests|2|1|
   >|temurin|5|1|
   >|unittests2|1|0|
   >|integration|3|0|
   >|integration1|1|0|
   >|integration2|1|0|
   >|custom-integration1|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18403      +/-   ##
   ============================================
   - Coverage     63.46%   55.41%   -8.05%     
   + Complexity     1701      852     -849     
   ============================================
     Files          3254     2544     -710     
     Lines        199104   147609   -51495     
     Branches      30830    23775    -7055     
   ============================================
   - Hits         126354    81801   -44553     
   + Misses        62665    58791    -3874     
   + Partials      10085     7017    -3068     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pinot/pull/18403/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/18403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration](https://app.codecov.io/gh/apache/pinot/pull/18403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration1](https://app.codecov.io/gh/apache/pinot/pull/18403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration2](https://app.codecov.io/gh/apache/pinot/pull/18403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [java-21](https://app.codecov.io/gh/apache/pinot/pull/18403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.41% <0.00%> (-8.05%)` | :arrow_down: |
   | [temurin](https://app.codecov.io/gh/apache/pinot/pull/18403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.41% <0.00%> (-8.05%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/pinot/pull/18403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.41% <0.00%> (-8.05%)` | :arrow_down: |
   | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/18403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.41% <0.00%> (-0.01%)` | :arrow_down: |
   | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/18403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/18403?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] fix(tls): log transient SSL factory renewal failures at WARN instead of INFO [pinot]

Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #18403:
URL: https://github.com/apache/pinot/pull/18403#issuecomment-4711293236

   Can you rebase this PR on the latest `master`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] fix(tls): log transient SSL factory renewal failures at WARN instead of INFO [pinot]

Posted by "dkranchii (via GitHub)" <gi...@apache.org>.
dkranchii commented on PR #18403:
URL: https://github.com/apache/pinot/pull/18403#issuecomment-4704935100

   @yashmayya 👀 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] fix(tls): tighten transient SSL factory renewal retry log message in RenewableTlsUtils [pinot]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #18403:
URL: https://github.com/apache/pinot/pull/18403


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] fix(tls): log transient SSL factory renewal failures at WARN instead of INFO [pinot]

Posted by "dkranchii (via GitHub)" <gi...@apache.org>.
dkranchii commented on PR #18403:
URL: https://github.com/apache/pinot/pull/18403#issuecomment-4365395376

   @Jackie-Jiang can you review this PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] fix(tls): log transient SSL factory renewal failures at WARN instead of INFO [pinot]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #18403:
URL: https://github.com/apache/pinot/pull/18403#issuecomment-4736557588

   Please also update the PR title and description to match the actual change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org