You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2019/02/08 00:01:38 UTC
Review Request 69926: Classification Updater: Updated to not use hard
coded qualifiedName
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69926/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3046
https://issues.apache.org/jira/browse/ATLAS-3046
Repository: atlas
Description
-------
Using _EntityType.getUniqueAttribute_ using REST client.
Diffs
-----
tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java 1e0b66dfc
Diff: https://reviews.apache.org/r/69926/diff/1/
Testing
-------
**Functional tests**
- Using user defined entity type.
- Using out of box types.
Thanks,
Ashutosh Mestry
Re: Review Request 69926: Classification Updater: Updated to not use
hard coded qualifiedName
Posted by Ashutosh Mestry <am...@hortonworks.com>.
> On Feb. 8, 2019, 12:31 a.m., Madhan Neethiraj wrote:
> > tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java
> > Lines 427 (patched)
> > <https://reviews.apache.org/r/69926/diff/1/?file=2124507#file2124507line427>
> >
> > Shouldn't line #427 be:
> >
> > return (String) header.getAttribute(getUniqueAttribute(header.getTypeName());
> >
> > Currently, this statement returns the name of the uniqueAttribute; and not entity attribute value.
Good catch!
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69926/#review212648
-----------------------------------------------------------
On Feb. 8, 2019, 12:01 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69926/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2019, 12:01 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3046
> https://issues.apache.org/jira/browse/ATLAS-3046
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Using _EntityType.getUniqueAttribute_ using REST client.
>
>
> Diffs
> -----
>
> tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java 1e0b66dfc
>
>
> Diff: https://reviews.apache.org/r/69926/diff/1/
>
>
> Testing
> -------
>
> **Functional tests**
> - Using user defined entity type.
> - Using out of box types.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 69926: Classification Updater: Updated to not use
hard coded qualifiedName
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69926/#review212648
-----------------------------------------------------------
tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java
Line 386 (original), 394 (patched)
<https://reviews.apache.org/r/69926/#comment298497>
There could be multiple entities for a given unique attribute value; only restriction is that for a given type there could be only one entity. So, consider using typeName + ":" + uniqueName as the key into the map.
tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java
Lines 427 (patched)
<https://reviews.apache.org/r/69926/#comment298498>
Shouldn't line #427 be:
return (String) header.getAttribute(getUniqueAttribute(header.getTypeName());
Currently, this statement returns the name of the uniqueAttribute; and not entity attribute value.
- Madhan Neethiraj
On Feb. 8, 2019, 12:01 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69926/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2019, 12:01 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3046
> https://issues.apache.org/jira/browse/ATLAS-3046
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Using _EntityType.getUniqueAttribute_ using REST client.
>
>
> Diffs
> -----
>
> tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java 1e0b66dfc
>
>
> Diff: https://reviews.apache.org/r/69926/diff/1/
>
>
> Testing
> -------
>
> **Functional tests**
> - Using user defined entity type.
> - Using out of box types.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 69926: Classification Updater: Updated to not use
hard coded qualifiedName
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69926/
-----------------------------------------------------------
(Updated Feb. 8, 2019, 6:55 p.m.)
Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Updates include: Addressed review comments.
Bugs: ATLAS-3046
https://issues.apache.org/jira/browse/ATLAS-3046
Repository: atlas
Description
-------
Using _EntityType.getUniqueAttribute_ using REST client.
Diffs (updated)
-----
tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java 1e0b66dfc
Diff: https://reviews.apache.org/r/69926/diff/3/
Changes: https://reviews.apache.org/r/69926/diff/2-3/
Testing
-------
**Functional tests**
- Using user defined entity type.
- Using out of box types.
Thanks,
Ashutosh Mestry
Re: Review Request 69926: Classification Updater: Updated to not use
hard coded qualifiedName
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69926/#review212661
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 8, 2019, 6:18 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69926/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2019, 6:18 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3046
> https://issues.apache.org/jira/browse/ATLAS-3046
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Using _EntityType.getUniqueAttribute_ using REST client.
>
>
> Diffs
> -----
>
> tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java 1e0b66dfc
>
>
> Diff: https://reviews.apache.org/r/69926/diff/2/
>
>
> Testing
> -------
>
> **Functional tests**
> - Using user defined entity type.
> - Using out of box types.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 69926: Classification Updater: Updated to not use
hard coded qualifiedName
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69926/
-----------------------------------------------------------
(Updated Feb. 8, 2019, 6:18 a.m.)
Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Updates include: Addressed review comments.
Bugs: ATLAS-3046
https://issues.apache.org/jira/browse/ATLAS-3046
Repository: atlas
Description
-------
Using _EntityType.getUniqueAttribute_ using REST client.
Diffs (updated)
-----
tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java 1e0b66dfc
Diff: https://reviews.apache.org/r/69926/diff/2/
Changes: https://reviews.apache.org/r/69926/diff/1-2/
Testing
-------
**Functional tests**
- Using user defined entity type.
- Using out of box types.
Thanks,
Ashutosh Mestry