You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ygerzhedovich (via GitHub)" <gi...@apache.org> on 2024/04/18 14:33:42 UTC
[PR] IGNITE-21923: Cover SQL E051-09(Basic query specification, Rename columns in the FROM clause) feature by tests [ignite-3]
ygerzhedovich opened a new pull request, #3628:
URL: https://github.com/apache/ignite-3/pull/3628
https://issues.apache.org/jira/browse/IGNITE-21923
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21923: Cover SQL E051-09(Basic query specification, Rename columns in the FROM clause) feature by tests [ignite-3]
Posted by "xtern (via GitHub)" <gi...@apache.org>.
xtern commented on code in PR #3628:
URL: https://github.com/apache/ignite-3/pull/3628#discussion_r1571028097
##########
modules/sql-engine/src/integrationTest/sql/basic_queries/rename_columns_in _from.test:
##########
@@ -0,0 +1,47 @@
+# name: sql/basic_queries/rename_columns_in _from.test
Review Comment:
is this space intentional (in filename also)?
##########
modules/sql-engine/src/integrationTest/sql/basic_queries/rename_columns_in _from.test:
##########
@@ -0,0 +1,47 @@
+# name: sql/basic_queries/rename_columns_in _from.test
+# description: SQL feature E051-9 (Basic query specification. Rename columns in the FROM clause)
+# feature: E051-09
+# group: [basic_queries]
+
+statement ok
+CREATE TABLE tab ( A INT PRIMARY KEY, B INT )
+
+statement ok
+INSERT INTO tab VALUES(1,13), (2,12), (3,11)
+
+query II
+SELECT ALL alias . X , Y FROM tab AS alias (X, Y) order by x
+----
+1 13
+2 12
+3 11
+
+query II
+SELECT DISTINCT alias.Y, X FROM tab AS alias (X, Y) order by y
+----
+11 3
+12 2
+13 1
+
+query II
+SELECT alias.X, Y FROM tab AS alias (X, Y) order by x
Review Comment:
I think it worth to add more similar test cases
```
SELECT X, alias.Y FROM tab AS alias (X, Y) - alias.Y
SELECT X, Y FROM tab AS alias (X, Y) order by x -- no alias
SELECT X, Y FROM tab alias (X, Y) order by x -- no AS
```
Should we also add a java test that checks the metadata (column names)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21923: Cover SQL E051-09(Basic query specification, Rename columns in the FROM clause) feature by tests [ignite-3]
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich merged PR #3628:
URL: https://github.com/apache/ignite-3/pull/3628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21923: Cover SQL E051-09(Basic query specification, Rename columns in the FROM clause) feature by tests [ignite-3]
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #3628:
URL: https://github.com/apache/ignite-3/pull/3628#discussion_r1572188895
##########
modules/sql-engine/src/integrationTest/sql/basic_queries/rename_columns_in _from.test:
##########
@@ -0,0 +1,47 @@
+# name: sql/basic_queries/rename_columns_in _from.test
+# description: SQL feature E051-9 (Basic query specification. Rename columns in the FROM clause)
+# feature: E051-09
+# group: [basic_queries]
+
+statement ok
+CREATE TABLE tab ( A INT PRIMARY KEY, B INT )
+
+statement ok
+INSERT INTO tab VALUES(1,13), (2,12), (3,11)
+
+query II
+SELECT ALL alias . X , Y FROM tab AS alias (X, Y) order by x
+----
+1 13
+2 12
+3 11
+
+query II
+SELECT DISTINCT alias.Y, X FROM tab AS alias (X, Y) order by y
+----
+11 3
+12 2
+13 1
+
+query II
+SELECT alias.X, Y FROM tab AS alias (X, Y) order by x
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21923: Cover SQL E051-09(Basic query specification, Rename columns in the FROM clause) feature by tests [ignite-3]
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #3628:
URL: https://github.com/apache/ignite-3/pull/3628#discussion_r1572188600
##########
modules/sql-engine/src/integrationTest/sql/basic_queries/rename_columns_in _from.test:
##########
@@ -0,0 +1,47 @@
+# name: sql/basic_queries/rename_columns_in _from.test
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org