[GitHub] [incubator-doris] morningman commented on a change in pull request #5737: [Compaction] Modify compaction logic

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #5737:
URL: https://github.com/apache/incubator-doris/pull/5737#discussion_r623570794



##########
File path: be/src/common/config.h
##########
@@ -283,8 +281,7 @@ CONF_mInt32(cumulative_compaction_skip_window_seconds, "30");
 CONF_mInt64(min_compaction_failure_interval_sec, "600"); // 10 min
 
 // This config can be set to limit thread number in compaction thread pool.
-CONF_mInt32(min_compaction_threads, "10");
-CONF_mInt32(max_compaction_threads, "10");
+CONF_Int32(max_compaction_threads, "10");

Review comment:
       It's OK for me~
   But I think the `min_compaction_threads` is meaning less for user, we should reduce unnecessary configuration items as much as possible




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org