[GitHub] michellethomas opened a new pull request #3651: Adding sort time table

[gi...@git.apache.org]

michellethomas opened a new pull request #3651: Adding sort time table
URL: https://github.com/apache/incubator-superset/pull/3651
 
 
   I'm enabling sorting on the time table visualization. Instead of just passing the component to row, I'm passing an object with the component to be displayed as well as the underlying data. Sending the data as value to `Td` allows reactable to sort by the data instead of the component that's getting displayed.
   
   By default it will sort by the first column in fd.column_collection and then users can toggle sort for any of the columns.
   
   I noticed a few issues with reactable, created an issue [here](https://github.com/glittershark/reactable/issues/390). If the user changes the first column (to adjust the sort), reactable doesn't correctly resort until the page is reloaded (or the columns are manually sorted). This will be an issue for anyone creating the charts but for those using them it should look fine.
   
   To sort the sparklines, I'm using the last value in the sparkline chart. Open to suggestions if you think there's a better way to sort this.
   
   ![superset_time_table_sort](https://user-images.githubusercontent.com/817955/31461569-c48e2b20-ae7e-11e7-915b-d62cf7a76a3f.gif)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services