[couchdb] branch master updated: test: port invalid_docids to Elixir test suite (#1968)

[ga...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

garren pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/couchdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 8efe9b2  test: port invalid_docids to Elixir test suite (#1968)
8efe9b2 is described below

commit 8efe9b29015549cc5d2d64033b2cf1e26fccfa53
Author: Alessio Biancalana <do...@gmail.com>
AuthorDate: Sun Mar 17 11:19:45 2019 +0100

    test: port invalid_docids to Elixir test suite (#1968)
---
 test/elixir/README.md                    |  2 +-
 test/elixir/test/invalid_docids_test.exs | 85 ++++++++++++++++++++++++++++++++
 2 files changed, 86 insertions(+), 1 deletion(-)

diff --git a/test/elixir/README.md b/test/elixir/README.md
index 883afb5..6f0fa29 100644
--- a/test/elixir/README.md
+++ b/test/elixir/README.md
@@ -51,7 +51,7 @@ X means done, - means partially
   - [ ] Port etags_views.js
   - [ ] Port form_submit.js
   - [ ] Port http.js
-  - [ ] Port invalid_docids.js
+  - [X] Port invalid_docids.js
   - [ ] Port jsonp.js
   - [X] Port large_docs.js
   - [ ] Port list_views.js
diff --git a/test/elixir/test/invalid_docids_test.exs b/test/elixir/test/invalid_docids_test.exs
new file mode 100644
index 0000000..edce5cc
--- /dev/null
+++ b/test/elixir/test/invalid_docids_test.exs
@@ -0,0 +1,85 @@
+defmodule InvalidDocIDsTest do
+  use CouchTestCase
+
+  @moduletag :invalid_doc_ids
+
+  @moduledoc """
+  Test invalid document ids
+  This is a port of the invalid_docids.js suite
+  """
+
+  @tag :with_db
+  test "_local-prefixed ids are illegal", context do
+    db_name = context[:db_name]
+
+    [
+      "/#{db_name}/_local",
+      "/#{db_name}/_local/",
+      "/#{db_name}/_local%2F",
+      "/#{db_name}/_local/foo/bar"
+    ]
+    |> Enum.each(fn url ->
+      %{status_code: status, body: body} = Couch.put(url, body: %{})
+      assert status === 400
+      assert body["error"] === "bad_request"
+    end)
+  end
+
+  @tag :with_db
+  test "using a non-string id is forbidden", context do
+    db_name = context[:db_name]
+    %{status_code: status, body: body} = Couch.post("/#{db_name}", body: %{:_id => 1})
+    assert status === 400
+    assert body["error"] === "illegal_docid"
+    assert body["reason"] === "Document id must be a string"
+  end
+
+  @tag :with_db
+  test "a PUT request with absent _id is forbidden", context do
+    db_name = context[:db_name]
+    %{status_code: status, body: body} = Couch.put("/#{db_name}/_other", body: %{})
+    assert status === 400
+    assert body["error"] === "illegal_docid"
+  end
+
+  @tag :with_db
+  test "accidental POST to form handling code", context do
+    db_name = context[:db_name]
+    %{status_code: status, body: body} = Couch.put("/#{db_name}/_tmp_view", body: %{})
+    assert status === 400
+    assert body["error"] === "illegal_docid"
+  end
+
+  @tag :with_db
+  test "invalid _prefix", context do
+    db_name = context[:db_name]
+
+    %{status_code: status, body: body} =
+      Couch.post("/#{db_name}", body: %{:_id => "_invalid"})
+
+    assert status === 400
+    assert body["error"] === "illegal_docid"
+    assert body["reason"] === "Only reserved document ids may start with underscore."
+  end
+
+  @tag :with_db
+  test "explicit _bulk_docks policy", context do
+    db_name = context[:db_name]
+    docs = [%{:_id => "_design/foo"}, %{:_id => "_local/bar"}]
+
+    %{status_code: status} = Couch.post("/#{db_name}/_bulk_docs", body: %{docs: docs})
+
+    assert status in [201, 202]
+
+    Enum.each(docs, fn %{:_id => id} ->
+      %{:body => %{"_id" => document_id}} = Couch.get("/#{db_name}/#{id}")
+      assert document_id === id
+    end)
+
+    %{status_code: invalid_status, body: invalid_body} =
+      Couch.post("/#{db_name}/_bulk_docs", body: %{docs: [%{:_id => "_invalid"}]})
+
+    assert invalid_status === 400
+    assert invalid_body["error"] === "illegal_docid"
+  end
+end