You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2012/05/15 20:28:20 UTC
Re: Review Request: OOZIE-821 Unit test to account for log retrieval from
multiple gzipped oozie.log files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4881/#review7902
-----------------------------------------------------------
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/4881/#comment17212>
can we have a function foo(File, String) which will write the string to the file? this will increase readability
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/4881/#comment17213>
can this just have only necessary info like 'debug', '_L19_' instead of a big string?..same comment for other places
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/4881/#comment17214>
is this required if the next call is close()?
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/4881/#comment17215>
did u mean 2012-03-24
- Virag
On 2012-04-26 00:15:30, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4881/
> -----------------------------------------------------------
>
> (Updated 2012-04-26 00:15:30)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Oozie.log files can be gzipped by a log setting and then we work with hourly .gz log files. For a long running job spanning multiple hours, OOZIE-590 fixed the log retrieval issue from multiple such gz files. I'm adding a unit test for checking this functionality.
>
>
> This addresses bug OOZIE-821.
> https://issues.apache.org/jira/browse/OOZIE-821
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1326832
>
> Diff: https://reviews.apache.org/r/4881/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-821 Unit test to account for log retrieval from
multiple gzipped oozie.log files
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
> On 2012-05-15 18:28:20, Virag Kothari wrote:
> > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java, line 214
> > <https://reviews.apache.org/r/4881/diff/1/?file=104416#file104416line214>
> >
> > can we have a function foo(File, String) which will write the string to the file? this will increase readability
> >
yes, since it is done similarly at more than one place
> On 2012-05-15 18:28:20, Virag Kothari wrote:
> > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java, line 224
> > <https://reviews.apache.org/r/4881/diff/1/?file=104416#file104416line224>
> >
> > is this required if the next call is close()?
right it is not. taking it out
> On 2012-05-15 18:28:20, Virag Kothari wrote:
> > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java, line 219
> > <https://reviews.apache.org/r/4881/diff/1/?file=104416#file104416line219>
> >
> > can this just have only necessary info like 'debug', '_L19_' instead of a big string?..same comment for other places
the XLogStreamer filter is defined in the beginning with parameters that keep it coherent-looking with the oozie log format. Hence I'm adding the big string to pass that filter.
> On 2012-05-15 18:28:20, Virag Kothari wrote:
> > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java, line 271
> > <https://reviews.apache.org/r/4881/diff/1/?file=104416#file104416line271>
> >
> > did u mean 2012-03-24
No, instead the parameter passed should be 2012, 4, 23. Fixing the date values in the log lines too
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4881/#review7902
-----------------------------------------------------------
On 2012-04-26 00:15:30, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4881/
> -----------------------------------------------------------
>
> (Updated 2012-04-26 00:15:30)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Oozie.log files can be gzipped by a log setting and then we work with hourly .gz log files. For a long running job spanning multiple hours, OOZIE-590 fixed the log retrieval issue from multiple such gz files. I'm adding a unit test for checking this functionality.
>
>
> This addresses bug OOZIE-821.
> https://issues.apache.org/jira/browse/OOZIE-821
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1326832
>
> Diff: https://reviews.apache.org/r/4881/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-821 Unit test to account for log retrieval from
multiple gzipped oozie.log files
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
> On 2012-05-15 18:28:20, Virag Kothari wrote:
> > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java, line 271
> > <https://reviews.apache.org/r/4881/diff/1/?file=104416#file104416line271>
> >
> > did u mean 2012-03-24
>
> Mona Chitnis wrote:
> No, instead the parameter passed should be 2012, 4, 23. Fixing the date values in the log lines too
adding short comment for this - month 00=Jan, hence for date 2012-04, calendar object should be provided with month-1 i.e. 3
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4881/#review7902
-----------------------------------------------------------
On 2012-04-26 00:15:30, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4881/
> -----------------------------------------------------------
>
> (Updated 2012-04-26 00:15:30)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Oozie.log files can be gzipped by a log setting and then we work with hourly .gz log files. For a long running job spanning multiple hours, OOZIE-590 fixed the log retrieval issue from multiple such gz files. I'm adding a unit test for checking this functionality.
>
>
> This addresses bug OOZIE-821.
> https://issues.apache.org/jira/browse/OOZIE-821
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1326832
>
> Diff: https://reviews.apache.org/r/4881/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona
>
>