You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/22 06:32:18 UTC

[GitHub] [skywalking-java] devkanro edited a comment on pull request #72: TracePathMatcher should match pattern "**" with paths end by "/" (#7875)

devkanro edited a comment on pull request #72:
URL: https://github.com/apache/skywalking-java/pull/72#issuecomment-975165175


   We should rearrange the rules so that we can analyze the edge conditions. 
   
   Basic:
   1. `?` matches any one char.
   2. `*` matches zero or more chars except '/'.
   3. `**` matches one or more path part.
   
   Edge(for *):
   1. `/eureka/*` matches `/eureka/`?
   2. `/eureka/*` matches `/eureka/test/`?
   3. `/eureka/*/` matches `/eureka/`?
   4. `/eureka/*/` matches `/eureka/test`?
   5. Is `/eureka/*` same as `/eureka/*/`?
   
   Edge(for **):
   1. `/eureka/**` matches `/eureka/`?
   2. `/eureka/**` matches `/eureka/test/`?
   3. `/eureka/**/` matches `/eureka/`?
   4. `/eureka/**/` matches `/eureka/test`?
   5. Is `/eureka/**` same as `/eureka/**/`?
   
   Edge(for normal):
   1. `/eureka/` matches `/eureka`?
   2. `/eureka` matches `/eureka/`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org