You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "shuolinl (via GitHub)" <gi...@apache.org> on 2023/09/22 07:27:11 UTC
[GitHub] [iotdb] shuolinl opened a new pull request, #11196: Sl fix auth bugs
shuolinl opened a new pull request, #11196:
URL: https://github.com/apache/iotdb/pull/11196
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #11196: Sl fix auth bugs
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #11196:
URL: https://github.com/apache/iotdb/pull/11196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] shuolinl commented on pull request #11196: Sl fix auth bugs
Posted by "shuolinl (via GitHub)" <gi...@apache.org>.
shuolinl commented on PR #11196:
URL: https://github.com/apache/iotdb/pull/11196#issuecomment-1731135598
> hi, It is recommended to hang the jira order number or ISSUES number.
Good idea. Before merging this pr, I will squash this two commit into one, and add jira number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on pull request #11196: Sl fix auth bugs
Posted by "wangchao316 (via GitHub)" <gi...@apache.org>.
wangchao316 commented on PR #11196:
URL: https://github.com/apache/iotdb/pull/11196#issuecomment-1731023921
hi, It is recommended to hang the jira order number or ISSUES number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] shuolinl commented on pull request #11196: Sl fix auth bugs
Posted by "shuolinl (via GitHub)" <gi...@apache.org>.
shuolinl commented on PR #11196:
URL: https://github.com/apache/iotdb/pull/11196#issuecomment-1731181633
In this pr:
1. avoid NPE when create view like: create view xx as select xx from xx.
2. user cannot create role with name "root" anymore.
3. when DBA try to delete user/role that not exists, he will get an error.
4. Allow user create user/role with "!@#$%&^*()_+-=", and refine error message.
5. refine TSStatus code used by auth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org