[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #10749: [feature-wip] (array-type) function concat_ws support array

[GitBox <gi...@apache.org>]

carlvinhust2012 commented on code in PR #10749:
URL: https://github.com/apache/doris/pull/10749#discussion_r917516156


##########
docs/en/docs/sql-manual/sql-functions/string-functions/concat_ws.md:
##########
@@ -28,10 +28,10 @@ under the License.
 ### Description
 #### Syntax
 
-`VARCHAR concat ws (VARCHAR sep, VARCHAR str,...)`
+`VARCHAR concat ws (VARCHAR sep, VARCHAR str,...) or VARCHAR concat_ws(VARCHAR sep, ARRAY array)`
 
 
-Using the first parameter SEP as a connector, the second parameter and all subsequent parameters are spliced into a string.
+Using the first parameter SEP as a connector, the second parameter and all subsequent parameters(or all string in an ARRAY) are spliced into a string.
 If the separator is NULL, return NULL.
 ` The concat_ws` function does not skip empty strings, but NULL values.

Review Comment:
   I think this line change to "The `concat_ws` function does not skip empty strings, it skips NULL values" is more more acurrate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org