You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/24 06:45:31 UTC

[GitHub] [doris] yiguolei commented on a diff in pull request #10397: [hotfix](dev-1.0.1) limit segment block size no more than 64M

yiguolei commented on code in PR #10397:
URL: https://github.com/apache/doris/pull/10397#discussion_r905764746


##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -935,13 +937,22 @@ Status SegmentIterator::next_batch(vectorized::Block* block) {
                 _current_return_columns[cid]->reserve(_opts.block_row_max);
             }
         }
+        //count non predicate column size
+        for (auto cid : _non_predicate_columns) {
+            return_column_row_length += _schema.column(cid)->length();
+        }
+        // the size of a block: no more than 64M
+        constexpr uint32_t max_block_size = 1024 * 64;

Review Comment:
   64k? or 64 MB?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org