You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2020/01/06 13:05:48 UTC
Review Request 71717: Made sure all targets are build for cmake
`tests` target.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71717/
-----------------------------------------------------------
Review request for mesos, Benno Evers and Till Toenshoff.
Repository: mesos
Description
-------
This target not only contains dependencies for the `test` target (which
actually exercises the tests), but alls all build dependencies so we can
make sure the targets still build.
Diffs
-----
src/tests/CMakeLists.txt 0a3c176d1bafc5445840146a1dd19a0825cab04d
Diff: https://reviews.apache.org/r/71717/diff/1/
Testing
-------
* `make tests`
* `make check`
Thanks,
Benjamin Bannier
Re: Review Request 71717: Made sure all targets are build for cmake
`tests` target.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71717/#review219131
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Jan. 6, 2020, 1:05 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71717/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2020, 1:05 p.m.)
>
>
> Review request for mesos, Benno Evers and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This target not only contains dependencies for the `test` target (which
> actually exercises the tests), but for all build dependencies so we can
> make sure the targets still build.
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt 0a3c176d1bafc5445840146a1dd19a0825cab04d
>
>
> Diff: https://reviews.apache.org/r/71717/diff/1/
>
>
> Testing
> -------
>
> * `make tests`
> * `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>