You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/01/19 18:52:33 UTC

[GitHub] [accumulo] ctubbsii commented on a change in pull request #2421: Remove obsolete comments and add minor improvements to OfflineIterator

ctubbsii commented on a change in pull request #2421:
URL: https://github.com/apache/accumulo/pull/2421#discussion_r788046235



##########
File path: core/src/main/java/org/apache/accumulo/core/clientImpl/OfflineIterator.java
##########
@@ -300,13 +295,9 @@ private TabletMetadata getTabletFiles(Range nextRange) {
     SamplerConfigurationImpl samplerConfImpl =
         SamplerConfigurationImpl.newSamplerConfig(acuTableConf);
 
-    if (scannerSamplerConfigImpl != null
-        && ((samplerConfImpl != null && !scannerSamplerConfigImpl.equals(samplerConfImpl))
-            || samplerConfImpl == null)) {
+    if (scannerSamplerConfigImpl != null && (!scannerSamplerConfigImpl.equals(samplerConfImpl))) {

Review comment:
       Can remove these extra parens:
   
   ```suggestion
       if (scannerSamplerConfigImpl != null && !scannerSamplerConfigImpl.equals(samplerConfImpl)) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org