You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/08/06 22:23:17 UTC
[Impala-ASF-CR] Print DebugString() when hitting DCHECK in BufferPool::Client
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11133
Change subject: Print DebugString() when hitting DCHECK in BufferPool::Client
......................................................................
Print DebugString() when hitting DCHECK in BufferPool::Client
To aid in debugging IMPALA-7402, print a bit more info when hitting the
DCHECK.
Change-Id: I334f323520f2174817c3400e660ce53efb10b16e
---
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
2 files changed, 15 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/11133/1
--
To view, visit http://gerrit.cloudera.org:8080/11133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I334f323520f2174817c3400e660ce53efb10b16e
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Print DebugString() when hitting DCHECK in BufferPool::Client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11133 )
Change subject: Print DebugString() when hitting DCHECK in BufferPool::Client
......................................................................
Print DebugString() when hitting DCHECK in BufferPool::Client
To aid in debugging IMPALA-7402, print a bit more info when hitting the
DCHECK.
Change-Id: I334f323520f2174817c3400e660ce53efb10b16e
Reviewed-on: http://gerrit.cloudera.org:8080/11133
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/bufferpool/buffer-pool-internal.h
M be/src/runtime/bufferpool/buffer-pool.cc
2 files changed, 15 insertions(+), 7 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I334f323520f2174817c3400e660ce53efb10b16e
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] Print DebugString() when hitting DCHECK in BufferPool::Client
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11133 )
Change subject: Print DebugString() when hitting DCHECK in BufferPool::Client
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334f323520f2174817c3400e660ce53efb10b16e
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 07 Aug 2018 00:59:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Print DebugString() when hitting DCHECK in BufferPool::Client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11133 )
Change subject: Print DebugString() when hitting DCHECK in BufferPool::Client
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334f323520f2174817c3400e660ce53efb10b16e
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 07 Aug 2018 05:22:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Print DebugString() when hitting DCHECK in BufferPool::Client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11133 )
Change subject: Print DebugString() when hitting DCHECK in BufferPool::Client
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334f323520f2174817c3400e660ce53efb10b16e
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 07 Aug 2018 08:48:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Print DebugString() when hitting DCHECK in BufferPool::Client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11133 )
Change subject: Print DebugString() when hitting DCHECK in BufferPool::Client
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2936/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334f323520f2174817c3400e660ce53efb10b16e
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 07 Aug 2018 05:22:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Print DebugString() when hitting DCHECK in BufferPool::Client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11133 )
Change subject: Print DebugString() when hitting DCHECK in BufferPool::Client
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/213/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I334f323520f2174817c3400e660ce53efb10b16e
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 22:58:22 +0000
Gerrit-HasComments: No