[GitHub] [spark] dongjoon-hyun commented on a change in pull request #23928: [SPARK-27023][K8S]configurable k8s client timeouts

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #23928: [SPARK-27023][K8S]configurable k8s client timeouts
URL: https://github.com/apache/spark/pull/23928#discussion_r262128948
 
 

 ##########
 File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
 ##########
 @@ -75,6 +75,12 @@ private[spark] object Config extends Logging {
       .toSequence
       .createWithDefault(Nil)
 
+  val SUBMISSION_CLIENT_PREFIX =
+      "spark.kubernetes.kubernetesClient.submission"
+  val DRIVER_CLIENT_PREFIX =
+      "spark.kubernetes.kubernetesClient.driver"
+  val CLIENT_MODE_CLIENT_PREFIX =
+      "spark.kubernetes.kubernetesClient"
 
 Review comment:
   Ur, please remove these lines and put the string to `ConfigBuilder`s. After that, we use `SUBMISSION_CLIENT_REQUEST_TIMEOUT.key` .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org