You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Ol...@Sun.COM on 2006/08/05 05:35:17 UTC
Regression Test Failure! - TinderBox_Derby 428930 - Sun DBTG
[Auto-generated mail]
*TinderBox_Derby* 428930/2006-08-05 02:32:58 CEST
*derbyall*
Failed Tests OK Skip Duration Platform
-------------------------------------------------------
*Jvm: 1.5*
23 687 664 2 145.86% SunOS-5.10_i86pc-i386
Details in http://www.multinet.no/~solberg/public/Apache/TinderBox_Derby/Limited/testSummary-428930.html
Attempted failure analysis in
http://www.multinet.no/~solberg/public/Apache/Failures/TinderBox_Derby/428930.html
Changes in http://www.multinet.no/~solberg/public/Apache/TinderBox_Derby/UpdateInfo/428930.txt
( All results in http://www.multinet.no/~solberg/public/Apache/index.html )
Re: Re: Regression Test Failure! - TinderBox_Derby 428930 - Sun DBTG
Posted by Andrew McIntyre <mc...@gmail.com>.
On 8/4/06, Daniel John Debrunner <dj...@apache.org> wrote:
>
> The URLCheck code uses it through reflection, that's probably why you
> missed it. I think the use of reflection (from what I remember) is over
> the top, a simple list of the required attributes in URLCheck would be
> good enough.
Yep, from org.apache.derby.tools.URLCheck:161,
Class att = Attribute.class;
This compiles in a direct reference to the class. At least it's an
easy fix. I think maybe a static initializer which populates
validDerbyProps with direct references to the keys from Attribute is
the way to go, along with a comment in Attribute to update URLCheck if
new attributes are added there. Sound good? Is there a better
solution?
andrew
Re: Regression Test Failure! - TinderBox_Derby 428930 - Sun DBTG
Posted by Daniel John Debrunner <dj...@apache.org>.
Andrew McIntyre wrote:
> On 8/4/06, Ole.Solberg@sun.com <Ol...@sun.com> wrote:
>
>> [Auto-generated mail]
>>
>> *TinderBox_Derby* 428930/2006-08-05 02:32:58 CEST
>> *derbyall*
>>
>> Failed Tests OK Skip Duration Platform
>> -------------------------------------------------------
>> *Jvm: 1.5*
>> 23 687 664 2 145.86% SunOS-5.10_i86pc-i386
>
>
> Due to one of my recent checkins, checked in the fix with revision
> 428952. Will file a JIRA to figure out why tools needs
> iapi.reference.Attribute, since that class contains only Strings from
> an interface, so it shouldn't be needed.
The URLCheck code uses it through reflection, that's probably why you
missed it. I think the use of reflection (from what I remember) is over
the top, a simple list of the required attributes in URLCheck would be
good enough.
Dan.
Re: Regression Test Failure! - TinderBox_Derby 428930 - Sun DBTG
Posted by Andrew McIntyre <mc...@gmail.com>.
On 8/4/06, Ole.Solberg@sun.com <Ol...@sun.com> wrote:
> [Auto-generated mail]
>
> *TinderBox_Derby* 428930/2006-08-05 02:32:58 CEST
> *derbyall*
>
> Failed Tests OK Skip Duration Platform
> -------------------------------------------------------
> *Jvm: 1.5*
> 23 687 664 2 145.86% SunOS-5.10_i86pc-i386
Due to one of my recent checkins, checked in the fix with revision
428952. Will file a JIRA to figure out why tools needs
iapi.reference.Attribute, since that class contains only Strings from
an interface, so it shouldn't be needed.
andrew