You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by pe...@apache.org on 2006/11/18 19:05:17 UTC
svn commit: r476574 - in
/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii:
DefaultNative2Ascii.java KaffeNative2Ascii.java Native2AsciiAdapter.java
Native2AsciiAdapterFactory.java SunNative2Ascii.java
Author: peterreilly
Date: Sat Nov 18 10:05:16 2006
New Revision: 476574
URL: http://svn.apache.org/viewvc?view=rev&rev=476574
Log:
checkstyle
Modified:
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/DefaultNative2Ascii.java
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/KaffeNative2Ascii.java
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapter.java
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapterFactory.java
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/SunNative2Ascii.java
Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/DefaultNative2Ascii.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/DefaultNative2Ascii.java?view=diff&rev=476574&r1=476573&r2=476574
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/DefaultNative2Ascii.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/DefaultNative2Ascii.java Sat Nov 18 10:05:16 2006
@@ -31,11 +31,17 @@
*/
public abstract class DefaultNative2Ascii implements Native2AsciiAdapter {
+ /** No-arg constructor. */
public DefaultNative2Ascii() {
}
/**
* Splits the task into setting up the command line switches
+ * @param args the native 2 ascii arguments.
+ * @param srcFile the source file.
+ * @param destFile the destination file.
+ * @return run if the conversion was successful.
+ * @throws BuildException if there is a problem.
* (delegated to {@link #setup setup}), adding the file names
* (delegated to {@link #addFiles addFiles}) and running the tool
* (delegated to {@link #run run}).
@@ -57,6 +63,7 @@
* @param cmd Command line to add to
* @param args provides the user-setting and access to Ant's
* logging system.
+ * @throws BuildException if there was a problem.
*/
protected void setup(Commandline cmd, Native2Ascii args)
throws BuildException {
@@ -77,6 +84,7 @@
* @param log provides access to Ant's logging system.
* @param src the source file
* @param dest the destination file
+ * @throws BuildException if there was a problem.
*/
protected void addFiles(Commandline cmd, ProjectComponent log, File src,
File dest) throws BuildException {
@@ -90,6 +98,7 @@
* @param cmd Command line to execute
* @param log provides access to Ant's logging system.
* @return whether execution was successful
+ * @throws BuildException if there was a problem.
*/
protected abstract boolean run(Commandline cmd, ProjectComponent log)
throws BuildException;
Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/KaffeNative2Ascii.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/KaffeNative2Ascii.java?view=diff&rev=476574&r1=476573&r2=476574
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/KaffeNative2Ascii.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/KaffeNative2Ascii.java Sat Nov 18 10:05:16 2006
@@ -42,6 +42,7 @@
*/
public static final String IMPLEMENTATION_NAME = "kaffe";
+ /** {@inheritDoc} */
protected void setup(Commandline cmd, Native2Ascii args)
throws BuildException {
if (args.getReverse()) {
@@ -50,6 +51,7 @@
super.setup(cmd, args);
}
+ /** {@inheritDoc} */
protected boolean run(Commandline cmd, ProjectComponent log)
throws BuildException {
ExecuteJava ej = new ExecuteJava();
@@ -77,9 +79,10 @@
try {
return Class.forName(N2A_CLASSNAMES[i]);
} catch (ClassNotFoundException cnfe) {
+ // Ignore
}
}
return null;
}
-}
\ No newline at end of file
+}
Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapter.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapter.java?view=diff&rev=476574&r1=476573&r2=476574
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapter.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapter.java Sat Nov 18 10:05:16 2006
@@ -35,7 +35,8 @@
* @param srcFile the source to convert
* @param destFile where to send output to
* @return whether the conversion has been successful.
+ * @throws BuildException if there was a problem.
*/
boolean convert(Native2Ascii args, File srcFile, File destFile)
throws BuildException;
-}
\ No newline at end of file
+}
Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapterFactory.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapterFactory.java?view=diff&rev=476574&r1=476573&r2=476574
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapterFactory.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/Native2AsciiAdapterFactory.java Sat Nov 18 10:05:16 2006
@@ -52,6 +52,7 @@
* @param log a ProjectComponent instance used to access Ant's
* logging system.
* @return The adapter to use.
+ * @throws BuildException if there was a problem.
*/
public static Native2AsciiAdapter getAdapter(String choice,
ProjectComponent log)
Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/SunNative2Ascii.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/SunNative2Ascii.java?view=diff&rev=476574&r1=476573&r2=476574
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/SunNative2Ascii.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/SunNative2Ascii.java Sat Nov 18 10:05:16 2006
@@ -35,6 +35,7 @@
*/
public static final String IMPLEMENTATION_NAME = "sun";
+ /** {@inheritDoc} */
protected void setup(Commandline cmd, Native2Ascii args)
throws BuildException {
if (args.getReverse()) {
@@ -43,6 +44,7 @@
super.setup(cmd, args);
}
+ /** {@inheritDoc} */
protected boolean run(Commandline cmd, ProjectComponent log)
throws BuildException {
try {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org