You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/05 23:28:07 UTC

[GitHub] [commons-vfs] efge commented on pull request #154: Rework SoftRefFilesCache locking

efge commented on pull request #154:
URL: https://github.com/apache/commons-vfs/pull/154#issuecomment-774342799


   Given that the Loom project will likely have issues with `synchronized` in its first iterations, I would not include the last commit switching from locks to synchronized. Otherwise the cleanups look good.
   
   I totally sympathise with @garydgregory about the lack of test, but also with @MaxKellermann in that writing tests that exercise thread-safety issues is a PITA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org