You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/13 08:30:19 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #19096: Improve stop scaling when running increment task.
azexcy opened a new pull request, #19096:
URL: https://github.com/apache/shardingsphere/pull/19096
Changes proposed in this pull request:
- Scaling IT case add stop/start case
- Temporary remove `create index ... on ...` sql, until support `create index if not exists`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #19096: Improve stop scaling when running increment task.
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #19096:
URL: https://github.com/apache/shardingsphere/pull/19096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #19096: Improve stop scaling when running increment task.
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #19096:
URL: https://github.com/apache/shardingsphere/pull/19096#discussion_r919961872
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/env/IntegrationTestEnvironment.java:
##########
@@ -175,4 +176,17 @@ public String getActualDataSourcePassword(final DatabaseType databaseType) {
public static IntegrationTestEnvironment getInstance() {
return INSTANCE;
}
+
+ /**
+ * Just get native database version.
+ * @param databaseType database type.
+ * @return if matched return version, otherwise return empty.
+ */
+ public List<String> getNativeDatabaseVersions(final String databaseType) {
+ if (StringUtils.equalsIgnoreCase(databaseType, getNativeDatabaseType())) {
+ // Just to occupy the space, will not really use.
+ return Collections.singletonList("keep");
+ }
+ return Collections.emptyList();
+ }
Review Comment:
For `getNativeDatabaseVersions`, it's better to rename it.
And return `Collections.singletonList("keep")` is not readable enough.
Is it possible to return `boolean`?
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/framework/container/database/OpenGaussContainer.java:
##########
@@ -54,6 +54,7 @@ protected void configure() {
withExposedPorts(port);
if (ScalingITEnvTypeEnum.NATIVE == IntegrationTestEnvironment.getInstance().getItEnvType()) {
addFixedExposedPort(port, port);
+ addFixedExposedPort(port + 1, port + 1);
}
Review Comment:
If `addFixedExposedPort(port + 1, port + 1);` is just for openGauss 3.0, maybe it's not necessary enable it always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19096: Improve stop scaling when running increment task.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19096:
URL: https://github.com/apache/shardingsphere/pull/19096#issuecomment-1183002776
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19096?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19096](https://codecov.io/gh/apache/shardingsphere/pull/19096?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87bfa62) into [master](https://codecov.io/gh/apache/shardingsphere/commit/04f011aa1b9892c93679da192db0e1000c00bcc2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04f011a) will **not change** coverage.
> The diff coverage is `25.00%`.
> :exclamation: Current head 87bfa62 differs from pull request most recent head 219b271. Consider uploading reports for the commit 219b271 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19096 +/- ##
=========================================
Coverage 59.38% 59.38%
Complexity 2321 2321
=========================================
Files 3804 3804
Lines 54718 54718
Branches 9228 9228
=========================================
Hits 32497 32497
Misses 19500 19500
Partials 2721 2721
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ine/scenario/rulealtered/RuleAlteredJobCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/19096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkSm9iQ2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/scenario/rulealtered/RuleAlteredJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/19096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkSm9iUHJlcGFyZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...gsphere/schedule/core/api/ModeScheduleContext.java](https://codecov.io/gh/apache/shardingsphere/pull/19096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjaGVkdWxlL2NvcmUvYXBpL01vZGVTY2hlZHVsZUNvbnRleHQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ext/distsql/ral/queryable/ShowInstanceHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/19096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3F1ZXJ5YWJsZS9TaG93SW5zdGFuY2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...mespace/parser/DataSourceBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/19096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtY29yZS1zcHJpbmctbmFtZXNwYWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcHJpbmcvbmFtZXNwYWNlL3BhcnNlci9EYXRhU291cmNlQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `88.09% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19096?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19096?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8c54d3d...219b271](https://codecov.io/gh/apache/shardingsphere/pull/19096?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org