You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2017/01/25 20:46:22 UTC

Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/
-----------------------------------------------------------

Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.


Repository: geode


Description
-------

Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
Changed single point of lucene index creation, no longer creating on the fly


Diffs
-----

  geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
  geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 

Diff: https://reviews.apache.org/r/55956/diff/


Testing
-------


Thanks,

Jason Huynh


Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/#review163079
-----------------------------------------------------------


Ship it!




Looks good. I think the synchronization issues I mentioned in the last review are still present, but maybe it would be good to get this in and continue working on cleaning that up.

- Dan Smith


On Jan. 26, 2017, 1:15 a.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55956/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2017, 1:15 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
> Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
> Changed single point of lucene index creation, no longer creating on the fly
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawIndexRepositoryFactory.java 2afccf9 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 960d794 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java 9201180 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 225f6ac 
> 
> Diff: https://reviews.apache.org/r/55956/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/#review163316
-----------------------------------------------------------


Ship it!




Ship It!

- nabarun nag


On Jan. 27, 2017, 7:05 a.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55956/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 7:05 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
> Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
> Changed single point of lucene index creation, no longer creating on the fly
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java 77333d4 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawIndexRepositoryFactory.java 2afccf9 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManager.java 64f2e56 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java ec94469 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 960d794 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java 9201180 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 225f6ac 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java 71172f0 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java 7426fa5 
> 
> Diff: https://reviews.apache.org/r/55956/diff/
> 
> 
> Testing
> -------
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/#review163317
-----------------------------------------------------------


Ship it!




Ship It!

- nabarun nag


On Jan. 27, 2017, 7:05 a.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55956/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 7:05 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
> Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
> Changed single point of lucene index creation, no longer creating on the fly
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java 77333d4 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawIndexRepositoryFactory.java 2afccf9 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManager.java 64f2e56 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java ec94469 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 960d794 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java 9201180 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 225f6ac 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java 71172f0 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java 7426fa5 
> 
> Diff: https://reviews.apache.org/r/55956/diff/
> 
> 
> Testing
> -------
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

Posted by Jason Huynh <jh...@pivotal.io>.

> On Jan. 27, 2017, 6:48 p.m., nabarun nag wrote:
> > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java, line 57
> > <https://reviews.apache.org/r/55956/diff/1/?file=1615356#file1615356line57>
> >
> >     We should now change the name of the file from to LucenePrimaryBucketListener to just LuceneBucketListener as this now also handles the event of becoming secondary

Good point, I'll rename it.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/#review163299
-----------------------------------------------------------


On Jan. 27, 2017, 7:05 a.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55956/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 7:05 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
> Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
> Changed single point of lucene index creation, no longer creating on the fly
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java 77333d4 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawIndexRepositoryFactory.java 2afccf9 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManager.java 64f2e56 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java ec94469 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 960d794 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java 9201180 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 225f6ac 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java 71172f0 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java 7426fa5 
> 
> Diff: https://reviews.apache.org/r/55956/diff/
> 
> 
> Testing
> -------
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/#review163299
-----------------------------------------------------------




geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java (line 57)
<https://reviews.apache.org/r/55956/#comment234725>

    We should now change the name of the file from to LucenePrimaryBucketListener to just LuceneBucketListener as this now also handles the event of becoming secondary


- nabarun nag


On Jan. 27, 2017, 7:05 a.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55956/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 7:05 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
> Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
> Changed single point of lucene index creation, no longer creating on the fly
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java 77333d4 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawIndexRepositoryFactory.java 2afccf9 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManager.java 64f2e56 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java ec94469 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 960d794 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java 9201180 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 225f6ac 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java 71172f0 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java 7426fa5 
> 
> Diff: https://reviews.apache.org/r/55956/diff/
> 
> 
> Testing
> -------
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

Posted by Jason Huynh <jh...@pivotal.io>.

> On Jan. 27, 2017, 7:22 p.m., nabarun nag wrote:
> > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java, line 62
> > <https://reviews.apache.org/r/55956/diff/3/?file=1617268#file1617268line62>
> >
> >     Can a call to afterSecondary at this point cause this to lose the lock.
> >     
> >     Also can using a single thread pool for afterPrimary and afterSecondary may result in performance issues if we have a lot of buckets and we write a test to keep moving buckets or changing the primary/secondary status very fast.

Yeah, we need to find a good way to protect against the "primary to secondary to primary to secondary" changes.  The single thread pool would have performance impact w.r.t. lucene index creation but prevent any weird locking issues.  That or we need to make after primary and after secondary trigger on the main thread and fix those locking issues...


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/#review163315
-----------------------------------------------------------


On Jan. 27, 2017, 7:05 a.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55956/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 7:05 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
> Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
> Changed single point of lucene index creation, no longer creating on the fly
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java 77333d4 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawIndexRepositoryFactory.java 2afccf9 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManager.java 64f2e56 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java ec94469 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 960d794 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java 9201180 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 225f6ac 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java 71172f0 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java 7426fa5 
> 
> Diff: https://reviews.apache.org/r/55956/diff/
> 
> 
> Testing
> -------
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/#review163315
-----------------------------------------------------------




geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java (line 62)
<https://reviews.apache.org/r/55956/#comment234735>

    Can a call to afterSecondary at this point cause this to lose the lock.
    
    Also can using a single thread pool for afterPrimary and afterSecondary may result in performance issues if we have a lot of buckets and we write a test to keep moving buckets or changing the primary/secondary status very fast.


- nabarun nag


On Jan. 27, 2017, 7:05 a.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55956/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 7:05 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
> Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
> Changed single point of lucene index creation, no longer creating on the fly
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java 77333d4 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawIndexRepositoryFactory.java 2afccf9 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManager.java 64f2e56 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java ec94469 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 960d794 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java 9201180 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 225f6ac 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java 71172f0 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java 7426fa5 
> 
> Diff: https://reviews.apache.org/r/55956/diff/
> 
> 
> Testing
> -------
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

Posted by Jason Huynh <jh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/
-----------------------------------------------------------

(Updated Jan. 27, 2017, 7:05 a.m.)


Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.


Changes
-------

Added retry on LuceneQueryImpl with a Max tries of 100 (arbitrary number but will prevent a hang for faster test failures when bucket repos are not found)
Moved afterSecondary to the wait thread pool to hopefully clear up some locking issues with concurrent updates while afterSecondary is called
The RawLuceneRepository was not creating the repo through the partition listener, so override the getRepo to do a lazy creation.  Because this isn't used for anything other than performance testing/comparison, I thought it would be ok to do this for now.
Modified the lock service that was used in the previous patch


Repository: geode


Description
-------

Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
Changed single point of lucene index creation, no longer creating on the fly


Diffs (updated)
-----

  geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
  geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java 77333d4 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawIndexRepositoryFactory.java 2afccf9 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManager.java 64f2e56 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java ec94469 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 
  geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 960d794 
  geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java 9201180 
  geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 225f6ac 
  geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java 71172f0 
  geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java 7426fa5 

Diff: https://reviews.apache.org/r/55956/diff/


Testing (updated)
-------

geode-lucene:precheckin


Thanks,

Jason Huynh


Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

Posted by Jason Huynh <jh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/
-----------------------------------------------------------

(Updated Jan. 26, 2017, 1:15 a.m.)


Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.


Changes
-------

Applied review suggestions/comments


Repository: geode


Description
-------

Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
Changed single point of lucene index creation, no longer creating on the fly


Diffs (updated)
-----

  geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
  geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawIndexRepositoryFactory.java 2afccf9 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 
  geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 960d794 
  geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java 9201180 
  geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 225f6ac 

Diff: https://reviews.apache.org/r/55956/diff/


Testing
-------


Thanks,

Jason Huynh


Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

Posted by Jason Huynh <jh...@pivotal.io>.

> On Jan. 25, 2017, 9:59 p.m., Dan Smith wrote:
> > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java, line 64
> > <https://reviews.apache.org/r/55956/diff/1/?file=1615354#file1615354line64>
> >
> >     This may somehow need to be synchronized with the cleanup code, to handle race conditions where we lose the primary status in the middle of this code.
> >     
> >     Maybe add all of these tasks to an a thread pool with a single thread? If you do that, make sure the thread pool is fair and garuantees the tasks will be executed in order.

I'll create a new ticket for this as it may have a bigger impact and require more tests/testing.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/#review163019
-----------------------------------------------------------


On Jan. 27, 2017, 7:05 a.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55956/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 7:05 a.m.)
> 
> 
> Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
> Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
> Changed single point of lucene index creation, no longer creating on the fly
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java 77333d4 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawIndexRepositoryFactory.java 2afccf9 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManager.java 64f2e56 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java ec94469 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java 960d794 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java 9201180 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java 225f6ac 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java 71172f0 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java 7426fa5 
> 
> Diff: https://reviews.apache.org/r/55956/diff/
> 
> 
> Testing
> -------
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55956/#review163019
-----------------------------------------------------------



Hey,

Looks like this is a big improvement on the reliability of this stuff. I have some comments, but if we need to tackle this incrementally thats fine.


geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java (line 122)
<https://reviews.apache.org/r/55956/#comment234399>

    Why is this doing a second get?



geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java (line 132)
<https://reviews.apache.org/r/55956/#comment234405>

    Maybe this should be remove instead of get?



geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java (line 64)
<https://reviews.apache.org/r/55956/#comment234408>

    This may somehow need to be synchronized with the cleanup code, to handle race conditions where we lose the primary status in the middle of this code.
    
    Maybe add all of these tasks to an a thread pool with a single thread? If you do that, make sure the thread pool is fair and garuantees the tasks will be executed in order.



geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java (line 58)
<https://reviews.apache.org/r/55956/#comment234402>

    Should probably be logged or something?



geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java (line 167)
<https://reviews.apache.org/r/55956/#comment234403>

    It would probably be better to pass in the lock service and the key to avoid casting and having this class know about a concrete bucket.



geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java (line 174)
<https://reviews.apache.org/r/55956/#comment234415>

    Maybe the unlock should be the last thing that happens, so that another member can't create a writer until after this member closes the writer.


- Dan Smith


On Jan. 25, 2017, 8:46 p.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55956/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 8:46 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added afterSecondary callback to partition listener to allow cleaning up of the index repo when the bucket losses primary
> Added lock prior to creating the bucket indexes to prevent multiple index writers from being available at a time
> Changed single point of lucene index creation, no longer creating on the fly
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java a534e50 
>   geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 7b79bfb 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java aa29e1b 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java c73d64a 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java f2c7c8f 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java d17b5f2 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java 4e86eb5 
> 
> Diff: https://reviews.apache.org/r/55956/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>